Add wagtail#13
Closed
marcoacierno wants to merge 11 commits intomasterfrom
Closed
Conversation
simobasso
requested changes
Jul 18, 2017
| @@ -1,3 +1,4 @@ | |||
| Django==1.11 | |||
Collaborator
There was a problem hiding this comment.
why the downgrade of django?
Member
Author
There was a problem hiding this comment.
The version of wagtail I used when I started the integration wasn't compatible with django 1.11 yet
|
|
||
| from wagtail.wagtailadmin import urls as wagtailadmin_urls | ||
| from wagtail.wagtailcore import urls as wagtail_urls | ||
| from wagtail.wagtaildocs import urls as wagtaildocs_urls |
| @@ -1,4 +1,4 @@ | |||
| Django==1.10.7 | |||
| @@ -2,3 +2,4 @@ Django==1.11.3 | |||
| wagtail==1.11.1 | |||
Collaborator
There was a problem hiding this comment.
please move this deps in production' dependencies
Member
Author
There was a problem hiding this comment.
Are you talking about 'psycopg2==2.7.1' and not wagtail?
Member
There was a problem hiding this comment.
I'd just use postgres everywhere :)
Collaborator
There was a problem hiding this comment.
'cause the actually default is sqlite.
If a collaborator w/o pg start an instances with that commit, the setup will fail.
options:
- move
psycopg2==2.7.1in production' dependencies - use pg as default in settings_base.py
Member
There was a problem hiding this comment.
let's use postgres everywhere :)
| @@ -136,7 +136,7 @@ | |||
| MEDIA_URL = '/media/' | |||
| @@ -4,7 +4,7 @@ | |||
|
|
|||
marcoacierno
force-pushed
the
feature/wagtail
branch
2 times, most recently
from
e5536c3 to
476d4ca
Compare
added 11 commits
July 23, 2017 22:54
I'm using Django 1.10 instead of 1.11 because Wagtail 1.9 doesn't support 1.11 yet.
marcoacierno
force-pushed
the
feature/wagtail
branch
from
476d4ca to
abd2f78
Compare
patrick91
approved these changes
Jul 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.