Skip to content

Update ScheduleItem admin: title first column, add rooms list#4656

Merged
marcoacierno merged 1 commit into
mainfrom
claude/issue-4655-20260527-0637
May 27, 2026
Merged

Update ScheduleItem admin: title first column, add rooms list#4656
marcoacierno merged 1 commit into
mainfrom
claude/issue-4655-20260527-0637

Conversation

@marcoacierno
Copy link
Copy Markdown
Member

Summary

  • Move title to be the first column in the ScheduleItem admin list view
  • Add rooms list column to display room names

Closes #4655

Generated with Claude Code

- Move title to be the first column in list_display
- Add rooms_list method to display room names in the list view

Closes #4655

Co-authored-by: Marco Acierno <marcoacierno@users.noreply.github.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pycon Error Error May 27, 2026 6:41am

@marcoacierno marcoacierno merged commit fbc823f into main May 27, 2026
6 of 7 checks passed
@marcoacierno marcoacierno deleted the claude/issue-4655-20260527-0637 branch May 27, 2026 06:41
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 27, 2026

Adds a rooms_list column to the ScheduleItemAdmin list view and reorders columns so title appears before conference.

Performance — implicit prefetch dependency

rooms_list calls obj.rooms.all() on every row, which would be N+1 without the existing prefetch_related("rooms") in get_queryset. It works correctly today, but the method is silently coupled to that prefetch. If the queryset is reused in an export action or another context without the prefetch, it will silently degrade. Consider adding rooms to the list_prefetch_related tuple if Django admin supports it, or at minimum leave a comment linking the two.

Minor — asymmetric @admin.display usage (pre-existing)

speakers_names at line 513 lacks the @admin.display(description=...) decorator that the new rooms_list correctly uses. Not introduced by this PR, but the juxtaposition makes it more visible.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.52%. Comparing base (3aead8c) to head (d529c57).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4656   +/-   ##
=======================================
  Coverage   92.52%   92.52%           
=======================================
  Files         359      359           
  Lines       10791    10791           
  Branches      821      821           
=======================================
  Hits         9984     9984           
  Misses        696      696           
  Partials      111      111           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Schedule item updates

1 participant