Skip to content

Require psutil#168

Merged
fabianp merged 5 commits intopythonprofilers:masterfrom
astrojuanlu:require-psutil
Oct 25, 2017
Merged

Require psutil#168
fabianp merged 5 commits intopythonprofilers:masterfrom
astrojuanlu:require-psutil

Conversation

@astrojuanlu
Copy link
Copy Markdown
Collaborator

This addresses the problem of running the tests remotely (see discussion in #166). Fortunately there are wheels for all platforms so this is easier than it used to be in the past :)

astrojuanlu and others added 5 commits October 25, 2017 19:07
Now the import does not work, needs fixing.
I admit the approach is complex... But it is the only
reliable way to do it with a single file.
@astrojuanlu astrojuanlu requested a review from fabianp October 25, 2017 17:23
Copy link
Copy Markdown
Collaborator

@fabianp fabianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! looks good to me!

@fabianp fabianp merged commit 15a7e12 into pythonprofilers:master Oct 25, 2017
@fabianp
Copy link
Copy Markdown
Collaborator

fabianp commented Oct 25, 2017

merged, thanks!

@fabianp
Copy link
Copy Markdown
Collaborator

fabianp commented Oct 25, 2017

@Juanlu001 : please also add your name to the README :-)

@astrojuanlu astrojuanlu deleted the require-psutil branch October 25, 2017 17:27
@astrojuanlu
Copy link
Copy Markdown
Collaborator Author

Will do :) Thanks @fabianp!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants