Make function legend in mprof plot unambiguous#218
Merged
astrojuanlu merged 3 commits intopythonprofilers:masterfrom Dec 13, 2018
Merged
Make function legend in mprof plot unambiguous#218astrojuanlu merged 3 commits intopythonprofilers:masterfrom
astrojuanlu merged 3 commits intopythonprofilers:masterfrom
Conversation
Previously, if the profiling was run on multiple same-named functions in different classes or modules, the plot legend did not make clear which bracket measured which function.
astrojuanlu
requested changes
Dec 13, 2018
Collaborator
astrojuanlu
left a comment
astrojuanlu
left a comment
There was a problem hiding this comment.
Thanks for your contribution and sorry for the late review! This will need a minor correction to get in.
astrojuanlu
approved these changes
Dec 13, 2018
Collaborator
|
Thanks a lot! |
Collaborator
|
thanks @Juanlu001 for the review and merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if the profiling was run on multiple same-named functions in
different classes or modules, the plot legend did not make clear which
bracket measured which function.