-
Notifications
You must be signed in to change notification settings - Fork 32
Attempt to fix reentrancy bugs #500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Benchmark resultsdiff --git a/benchmarks/results/lots-of-peaks.json b/benchmarks/results/lots-of-peaks.json
index 383499f..c28df74 100644
--- a/benchmarks/results/lots-of-peaks.json
+++ b/benchmarks/results/lots-of-peaks.json
@@ -1,12 +1,12 @@
{
"D1mr": [-"3771157 (188.06264867688517%)",-]{+"5024794 (217.29838032892047%)",+}
"D1mw": [-"2763734 (1002.7001956474165%)",-]{+"3868520 (1362.3781600080927%)",+}
"DLmr": [-"1492746 (2257.3344509639564%)",-]{+"2003825 (3124.367604443371%)",+}
"DLmw": [-"1858942 (1333.7673887649994%)",-]{+"2948531 (2058.467117892038%)",+}
"Dr": [-"231060633 (375.8621692938787%)",-]{+"246476484 (396.18445815976753%)",+}
"Dw": [-"88001037 (338.04076205255154%)",-]{+"94152016 (356.433443695857%)",+}
"I1mr": [-"3555117 (1291.257363437142%)",-]{+"5050419 (1768.8648695088987%)",+}
"ILmr": [-"14685 (224.7663551401869%)",-]{+"16315 (234.91275944761432%)",+}
"Ir": [-"872039764 (403.39198904097907%)",-]{+"982728639 (443.8389037507809%)",+}
"Overall": [-"1332452656 (406.55387644593173%)"-]{+"1528192201 (453.59889572736466%)"+}
}
diff --git a/benchmarks/results/multithreading-1.json b/benchmarks/results/multithreading-1.json
index 2d9d2d5..33be630 100644
--- a/benchmarks/results/multithreading-1.json
+++ b/benchmarks/results/multithreading-1.json
@@ -1,12 +1,12 @@
{
"D1mr": [-"1866984 (413.64545831772375%)",-]{+"2080030 (447.6543696849762%)",+}
"D1mw": [-"393456 (455.7661355950594%)",-]{+"348733 (415.3985294250649%)",+}
"DLmr": [-"59324 (493.26483261518064%)",-]{+"79689 (640.1911605206074%)",+}
"DLmw": [-"77459 (220.9427598913281%)",-]{+"97662 (253.0416523020027%)",+}
"Dr": [-"77161209 (571.2328286082947%)",-]{+"62175289 (486.23169756350586%)",+}
"Dw": [-"30820902 (440.2169730406361%)",-]{+"27909629 (412.87499396045706%)",+}
"I1mr": [-"1638950 (586.5692113122628%)",-]{+"1593358 (567.6361651297524%)",+}
"ILmr": [-"7958 (171.83607149304927%)",-]{+"8431 (174.3868007764249%)",+}
"Ir": [-"254542209 (491.30873094686683%)",-]{+"221465576 (445.78673315006233%)",+}
"Overall": [-"382464110 (492.83707107089475%)"-]{+"333212438 (447.23892158744746%)"+}
}
diff --git a/benchmarks/results/pystone.json b/benchmarks/results/pystone.json
index 3970408..cd86f99 100644
--- a/benchmarks/results/pystone.json
+++ b/benchmarks/results/pystone.json
@@ -1,12 +1,12 @@
{
"D1mr": [-"4542966 (144.07376585255872%)",-]{+"8917115 (196.1105840563899%)",+}
"D1mw": [-"1628141 (267.75567903740483%)",-]{+"1589428 (239.94658984150408%)",+}
"DLmr": [-"32802 (331.7507418397626%)",-]{+"41575 (401.5303162170003%)",+}
"DLmw": [-"65725 (241.46577701248387%)",-]{+"74354 (260.7688814893295%)",+}
"Dr": [-"367659717 (157.6310977517437%)",-]{+"378768989 (159.42226021855814%)",+}
"Dw": [-"143586175 (159.9837295595579%)",-]{+"137547492 (157.48575732526194%)",+}
"I1mr": [-"8784651 (214.74165578852526%)",-]{+"10526875 (235.63627400527707%)",+}
"ILmr": [-"7924 (170.99086185271457%)",-]{+"8259 (172.45372401087815%)",+}
"Ir": [-"1160233461 (157.01681262908485%)",-]{+"1329110823 (165.344793330647%)",+}
"Overall": [-"1734495915 (158.00764418609307%)"-]{+"1933286616 (164.7552117094729%)"+}
}
diff --git a/benchmarks/results/version.txt b/benchmarks/results/version.txt
index d8f4897..e98ec41 100644
--- a/benchmarks/results/version.txt
+++ b/benchmarks/results/version.txt
@@ -1 +1 @@
[-2021.9.2.dev9+gc3af8e6.d20211105-]{+2023.3.1.dev8+g7aa6d0b.d20230314+} |
|
Sure -- how would I do that? |
|
Can you try the version included in the zip file above? Thanks! (it includes Python 3.10 inside the zip) |
|
@joshfactorial if you have time today, would love to hear if this fixes it. |
|
I will run it today!
Get BlueMail for Android<https://bluemail.me>
On Mar 15, 2023, at 9:43 AM, Itamar Turner-Trauring ***@***.******@***.***>> wrote:
@joshfactorial<https://urldefense.com/v3/__https://github.com/joshfactorial__;!!DZ3fjg!4tMpIRUPTJY1-381OUsWDdcVoQIL-j3yTtN64csBdZyBtVkC9ly8iPg6gzUrLa1p2b7np5u7Hzl9rq1--3dkVoGashCdsA$> if you have time today, would love to hear if this fixes it.
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/pythonspeed/filprofiler/pull/500*issuecomment-1470135715__;Iw!!DZ3fjg!4tMpIRUPTJY1-381OUsWDdcVoQIL-j3yTtN64csBdZyBtVkC9ly8iPg6gzUrLa1p2b7np5u7Hzl9rq1--3dkVoFPI5s42Q$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AGMI72ZVAKVASM4PI3ZC3U3W4HIQ7ANCNFSM6AAAAAAV27D5TE__;!!DZ3fjg!4tMpIRUPTJY1-381OUsWDdcVoQIL-j3yTtN64csBdZyBtVkC9ly8iPg6gzUrLa1p2b7np5u7Hzl9rq1--3dkVoGmcF4EZw$>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
It'll be awhile before I see any final results, but it IS running! |
|
I wasn't sure how to approach it so I just started attempting to install the lowest numbered file in the zip. The correct one ended up being |
|
The "manylinux2014" means "this will work on RHEL7 or later", or more accurately, versions of glibc matching RHEL7's or later. "manylinux_2_17" means "glibc 2.17 or later", which is what RHEL7 uses. |
|
It worked! |
|
Great, thank you! |
Fixes #485, maybe. Will need @joshfactorial to test the generated wheels to verify.