FIX: compatibility with python3.7 #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrocklin
reviewed
Nov 16, 2017
| def __name__(self): | ||
| try: | ||
| return '_of_'.join( | ||
| f.__name__ for f in reversed((self.first,) + self.funcs), |
Member
There was a problem hiding this comment.
Can we just drop the comma instead?
This expression is broken by: bpo-32012: Disallow trailing comma after genexpr without parenthesis. python/cpython#4382 python/cpython@9165f77
tacaswell
force-pushed
the
fix_37compat
branch
from
ebf7e74 to
8aba715
Compare
Contributor
Author
|
I'm still waiting for my test env to rebuild locally.... |
Contributor
Author
|
👍 installs locally. I think that the 3.7-dev env is an 'old' version of 3.7 as I get local test failures due to lacking introspection on |
Member
|
LGTM. Thanks, @tacaswell! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expression is broken by:
bpo-32012: Disallow trailing comma after genexpr without
parenthesis.
python/cpython#4382
python/cpython@9165f77