Skip to content

FIX: compatibility with python3.7 #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 16, 2017
Merged

FIX: compatibility with python3.7 #386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5eb9fcb
FIX: compatibility with python3.7
tacaswell Nov 16, 2017
8aba715
CI: add 3.7-dev to test matrix
tacaswell Nov 16, 2017
255c908
TST: do not worry abount having good introspection on breakpoint
tacaswell Nov 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,16 @@ python:
- "3.4"
- "3.5"
- "3.6"
- "3.7-dev"
- "pypy"

env:
- PEP8_IGNORE="E731,W503,E402"

matrix:
allow_failures:
- python: "3.7-dev"

# command to install dependencies
install:
- pip install coverage pep8 pytest
Expand Down
2 changes: 1 addition & 1 deletion toolz/functoolz.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,7 @@ def composed_doc(*fs):
def __name__(self):
try:
return '_of_'.join(
f.__name__ for f in reversed((self.first,) + self.funcs),
Copy link
Member

@mrocklin mrocklin Nov 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just drop the comma instead?

Copy link
Contributor Author

@tacaswell tacaswell Nov 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

f.__name__ for f in reversed((self.first,) + self.funcs)
)
except AttributeError:
return type(self).__name__
Expand Down
2 changes: 1 addition & 1 deletion toolz/tests/test_inspect_args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,7 @@ def add_blacklist(mod, attr):
blacklist.add(getattr(mod, attr))

add_blacklist(builtins, 'basestring')
add_blacklist(builtins, 'breakpoint')
add_blacklist(builtins, 'NoneType')
add_blacklist(builtins, '__metaclass__')
add_blacklist(builtins, 'sequenceiterator')
Expand Down Expand Up @@ -497,4 +498,3 @@ def __wrapped__(self):
assert num_required_args(Wrapped) == (False if PY33 else None)
_sigs.signatures[Wrapped] = (_sigs.expand_sig((0, lambda func: None)),)
assert num_required_args(Wrapped) == 1