-
Notifications
You must be signed in to change notification settings - Fork 3
Split out the Meta AWS H100 to a separate check #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AWS H100 check regularly flaps due to it being a limited resource and seems like it can regularly queue for 3 or 4 hrs, even occassionally going as high as 5-6 hrs. Split the check out and set the check time to 4 hrs so that it flaps hopefully less. Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
|
OpenTofu plan for prod Plan: 1 to add, 1 to change, 0 to destroy.OpenTofu used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
!~ update in-place
OpenTofu will perform the following actions:
# datadog_synthetics_test.pytorch-gha-runners-queue-check-meta will be updated in-place
!~ resource "datadog_synthetics_test" "pytorch-gha-runners-queue-check-meta" {
id = "nnz-icu-8qk"
name = "GHA Runner Queue Check - Meta Runners"
tags = [
"env:project",
"project:pytorch",
"service:gha-runners",
]
# (10 unchanged attributes hidden)
!~ assertion {
!~ code = <<-EOT
dd.expect(dd.response.statusCode).to.equal(200);
- const EXCLUDED_MACHINE_PATTERNS = ['.dgx.', '.rocm.', '.s390x', '^lf\\.'];
+ const EXCLUDED_MACHINE_PATTERNS = ['.dgx.', '.rocm.', '.s390x', '^lf\\.', '^linux.aws.h100'];
const jsonData = dd.response.body;
const parsedData = JSON.parse(jsonData);
const highQueueItems = parsedData
.filter(item => {
const machineType = item.machine_type;
return !EXCLUDED_MACHINE_PATTERNS.some(pattern =>
pattern.startsWith('^') ?
new RegExp(pattern).test(machineType) :
machineType.includes(pattern)
) && item.avg_queue_s > 7200;
})
.map(item => ({ machine_type: item.machine_type, avg_queue_s: item.avg_queue_s }));
if (highQueueItems.length > 0) {
const machineDetails = highQueueItems
.map(item => `${item.machine_type} (${item.avg_queue_s}s)`)
.join(', ');
const message = `High queue detected for machine types: ${machineDetails}`;
console.error(message);
}
dd.expect(highQueueItems.length > 0).to.be.false;
EOT
# (1 unchanged attribute hidden)
}
# (2 unchanged blocks hidden)
}
# datadog_synthetics_test.pytorch-gha-runners-queue-check-meta-h100 will be created
+ resource "datadog_synthetics_test" "pytorch-gha-runners-queue-check-meta-h100" {
+ id = (known after apply)
+ locations = [
+ "aws:us-west-2",
]
+ message = <<-EOT
Detected GitHub Runner Queue - Meta Runners - AWS H100 has jobs waiting
unusually long for runners.
{{synthetics.attributes.result.failure.message}}
Check https://hud.pytorch.org/metrics for more details.
@slack-pytorch-infra-alerts
EOT
+ monitor_id = (known after apply)
+ name = "GHA Runner Queue Check - Meta Runners - AWS H100"
+ status = "live"
+ tags = [
+ "env:project",
+ "project:pytorch",
+ "service:gha-runners",
]
+ type = "api"
+ assertion {
+ code = <<-EOT
dd.expect(dd.response.statusCode).to.equal(200);
const EXCLUDED_MACHINE_PATTERNS = ['.dgx.', '.rocm.', '.s390x', '^lf\\.', '^linux.aws.h100'];
const jsonData = dd.response.body;
const parsedData = JSON.parse(jsonData);
const highQueueItems = parsedData
.filter(item => {
const machineType = item.machine_type;
return !EXCLUDED_MACHINE_PATTERNS.some(pattern =>
pattern.startsWith('^') ?
new RegExp(pattern).test(machineType) :
machineType.includes(pattern)
) && item.avg_queue_s > 7200;
})
.map(item => ({ machine_type: item.machine_type, avg_queue_s: item.avg_queue_s }));
if (highQueueItems.length > 0) {
const machineDetails = highQueueItems
.map(item => `${item.machine_type} (${item.avg_queue_s}s)`)
.join(', ');
const message = `High queue detected for machine types: ${machineDetails}`;
console.error(message);
}
dd.expect(highQueueItems.length > 0).to.be.false;
EOT
+ type = "javascript"
}
+ options_list {
+ http_version = "any"
+ min_location_failed = 1
+ tick_every = 900
}
+ request_definition {
+ method = "GET"
+ url = "https://hud.pytorch.org/api/clickhouse/queued_jobs_by_label?parameters=%7B%7D"
}
}
Plan: 1 to add, 1 to change, 0 to destroy.✅ Plan applied in Tofu Apply #27 |
Contributor
|
I think that megalinter grype error is either an upstream issue or transient network thing - tried retriggering. If it doesn't work, maybe we add a config to ignore the check, since I suspect the chances of any CVEs in our terraform is pretty low. |
jordanconway
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AWS H100 check regularly flaps due to it being a limited resource and seems like it can regularly queue for 3 or 4 hrs, even occassionally going as high as 5-6 hrs. Split the check out and set the check time to 4 hrs so that it flaps hopefully less.