Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Sep 13, 2024

resolving some compatibility issues:
AttributeError: np.float_was removed in the NumPy 2.0 release. Usenp.float64 instead.
coming from third-party dependencies


📚 Documentation preview 📚: https://pytorch-tabular--482.org.readthedocs.build/en/482/

@Borda Borda requested a review from manujosephv September 13, 2024 19:30
@Borda Borda enabled auto-merge (squash) September 13, 2024 19:49
@Borda
Copy link
Collaborator Author

Borda commented Sep 13, 2024

the failing docs build can be related to mkdocs/mkdocs#3528 (comment)

@Borda Borda changed the title freeze numpy <2.0 freeze numpy <2.0 & fix ci+docs Sep 13, 2024
@Borda
Copy link
Collaborator Author

Borda commented Sep 13, 2024

@manujosephv This solves 3 actual issues preventing any merge:

  • compatibility issues with the latest numpy 2+
  • false package check dues to old twine
  • building docs failed due to wrong dev versions

@Borda Borda disabled auto-merge September 13, 2024 20:06
@Borda Borda enabled auto-merge (squash) September 13, 2024 20:06
@Borda Borda added the bug Something isn't working label Sep 14, 2024
@Borda Borda merged commit c762eea into main Sep 16, 2024
@Borda Borda deleted the req/numpy branch September 16, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants