disable random init in inference operator for embedding cache #5026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
emlin
added a commit
to emlin/FBGEMM
that referenced
this pull request
Oct 19, 2025
…h#5026) Summary: X-link: meta-pytorch/torchrec#3466 X-link: facebookresearch/FBGEMM#2040 For embedding cache mode, we do not expect random value if there is cache missing. This diff passed the embedding cache mode to inference operator, and use that to disable the backend random initialization. Differential Revision: D84367061
emlin
added a commit
to emlin/FBGEMM
that referenced
this pull request
Oct 19, 2025
…h#5026) Summary: X-link: meta-pytorch/torchrec#3466 X-link: facebookresearch/FBGEMM#2040 For embedding cache mode, we do not expect random value if there is cache missing. This diff passed the embedding cache mode to inference operator, and use that to disable the backend random initialization. Differential Revision: D84367061
emlin
added a commit
to emlin/torchrec
that referenced
this pull request
Oct 19, 2025
…ytorch#3466) Summary: X-link: pytorch/FBGEMM#5026 X-link: facebookresearch/FBGEMM#2040 For embedding cache mode, we do not expect random value if there is cache missing. This diff passed the embedding cache mode to inference operator, and use that to disable the backend random initialization. Differential Revision: D84367061
…h#5026) Summary: X-link: meta-pytorch/torchrec#3466 X-link: facebookresearch/FBGEMM#2040 For embedding cache mode, we do not expect random value if there is cache missing. This diff passed the embedding cache mode to inference operator, and use that to disable the backend random initialization. Differential Revision: D84367061
emlin
force-pushed
the
export-D84367061
branch
from
2097ba0 to
0830111
Compare
emlin
added a commit
to emlin/FBGEMM
that referenced
this pull request
Oct 20, 2025
…h#5026) Summary: X-link: meta-pytorch/torchrec#3466 X-link: facebookresearch/FBGEMM#2040 For embedding cache mode, we do not expect random value if there is cache missing. This diff passed the embedding cache mode to inference operator, and use that to disable the backend random initialization. Differential Revision: D84367061
Contributor
|
This pull request has been merged in 98ee828. |
meta-codesync bot
pushed a commit
to meta-pytorch/torchrec
that referenced
this pull request
Oct 20, 2025
Summary: X-link: pytorch/FBGEMM#5026 Pull Request resolved: #3466 X-link: https://github.com/facebookresearch/FBGEMM/pull/2040 For embedding cache mode, we do not expect random value if there is cache missing. This diff passed the embedding cache mode to inference operator, and use that to disable the backend random initialization. Differential Revision: D84367061 fbshipit-source-id: 83687bcb7c097f60b583c00bf80956efcdcd3a9d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: meta-pytorch/torchrec#3466
X-link: https://github.com/facebookresearch/FBGEMM/pull/2040
For embedding cache mode, we do not expect random value if there is cache missing.
This diff passed the embedding cache mode to inference operator, and use that to disable the backend random initialization.
Differential Revision: D84367061