Add table_names as a instance variable of SplitTableBatchedEmbeddingBagsCodegen #5133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@FriedCosey has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87089649. |
…agsCodegen (pytorch#5133) Summary: X-link: facebookresearch/FBGEMM#2135 `table_names` is required for raw embedded streaming to support tracking in mpzch modules. Example usage in embedding module to look up raw ids ``` assert hasattr( self.emb_module, "res_params" ), "res_params should exist when raw_id_tracker is enabled" res_params: RESParams = self.emb_module.res_params # pyre-ignore[9] table_names = res_params.table_names raw_ids_dict = raw_id_tracker_wrapper.get_indexed_lookups( table_names, self.emb_module.uuid ) ``` `table_names` only exist when raw embedded streaming is enabled. During testing, we may disable raw embedded streaming (hence no `res_params`) this tight coupling makes testing difficult. This diff adds `table_names` as a instance variable of `SplitTableBatchedEmbeddingBagsCodegen` so we can easily retrieve `table_names` w/o depending on raw embedded streaming. Reviewed By: chouxi Differential Revision: D87089649
FriedCosey
force-pushed
the
export-D87089649
branch
from
fa5b98a to
7b662e7
Compare
Contributor
|
This pull request has been merged in 8189ad4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/2135
table_namesis required for raw embedded streaming to support tracking in mpzch modules.Example usage in embedding module to look up raw ids
table_namesonly exist when raw embedded streaming is enabled.During testing, we may disable raw embedded streaming (hence no
res_params) this tight coupling makes testing difficult. This diff addstable_namesas a instance variable ofSplitTableBatchedEmbeddingBagsCodegenso we can easily retrievetable_namesw/o depending on raw embedded streaming.Differential Revision: D87089649