Remove _test suffix from package name for test channel builds (#5502)#5502
Closed
gchalump wants to merge 1 commit into
Closed
Remove _test suffix from package name for test channel builds (#5502)#5502gchalump wants to merge 1 commit into
gchalump wants to merge 1 commit into
Conversation
Contributor
meta-codesync
Bot
changed the title
gchalump
force-pushed
the
export-D97372813
branch
3 times, most recently
from
d137455 to
9febed4
Compare
Summary: Pull Request resolved: #5502 X-link: https://github.com/facebookresearch/FBGEMM/pull/2474 When building FBGEMM_GPU with the "test" package channel (e.g. for PyPI release validation), the package name incorrectly included a `_test` suffix (e.g. `fbgemm_gpu_test-1.6.0rc1-cp310-cp310-manylinux_2_28_x86_64.whl`). This changes the condition in `setup.py` `package_name()` so that only the "nightly" channel appends a channel suffix (`_nightly`). Both "test" and "release" channels now produce the clean package name `fbgemm_gpu`. Reviewed By: spcyppt, q10 Differential Revision: D97372813
gchalump
force-pushed
the
export-D97372813
branch
from
9febed4 to
78b7dc4
Compare
Contributor
|
This pull request has been merged in 168eb9a. |
gchalump
added a commit
that referenced
this pull request
Mar 25, 2026
Summary: Pull Request resolved: #5502 X-link: facebookresearch/FBGEMM#2474 When building FBGEMM_GPU with the "test" package channel (e.g. for PyPI release validation), the package name incorrectly included a `_test` suffix (e.g. `fbgemm_gpu_test-1.6.0rc1-cp310-cp310-manylinux_2_28_x86_64.whl`). This changes the condition in `setup.py` `package_name()` so that only the "nightly" channel appends a channel suffix (`_nightly`). Both "test" and "release" channels now produce the clean package name `fbgemm_gpu`. Reviewed By: spcyppt, q10 Differential Revision: D97372813 fbshipit-source-id: 5d15b3839f4177d0312097a6100e5f196c98e81a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/2474
When building FBGEMM_GPU with the "test" package channel (e.g. for PyPI release
validation), the package name incorrectly included a
_testsuffix(e.g.
fbgemm_gpu_test-1.6.0rc1-cp310-cp310-manylinux_2_28_x86_64.whl).This changes the condition in
setup.pypackage_name()so that only the"nightly" channel appends a channel suffix (
_nightly). Both "test" and"release" channels now produce the clean package name
fbgemm_gpu.Reviewed By: spcyppt, q10
Differential Revision: D97372813