Skip to content

Conversation

@lanluo-nvidia
Copy link
Collaborator

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@meta-cla meta-cla bot added the cla signed label Oct 31, 2025
@lanluo-nvidia lanluo-nvidia marked this pull request as ready for review October 31, 2025 15:47
@narendasan narendasan requested a review from apbose October 31, 2025 15:57
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apbose
Copy link
Collaborator

apbose commented Oct 31, 2025

LGTM. Is this change added due to addition of cu129 in torch2.10 CI as was being discussed in the meeting yesterday? Also how do you know the specific version? You get it from the documentation somewhere?

@lanluo-nvidia lanluo-nvidia merged commit 8988e88 into main Oct 31, 2025
214 of 235 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants