Skip to content

waive(test): skip refit tests that fail on TensorRT-RTX#4193

Merged
lanluo-nvidia merged 1 commit into
pytorch:mainfrom
tp5uiuc:fix/pipeline-failures
Apr 16, 2026
Merged

waive(test): skip refit tests that fail on TensorRT-RTX#4193
lanluo-nvidia merged 1 commit into
pytorch:mainfrom
tp5uiuc:fix/pipeline-failures

Conversation

@tp5uiuc
Copy link
Copy Markdown
Collaborator

@tp5uiuc tp5uiuc commented Apr 16, 2026

Description

Skip two refit tests that are causing pipeline failures on TensorRT-RTX:

  • test_refit_one_engine_with_wrong_weightmap: Refit with a wrong weightmap gives incorrect results on TensorRT-RTX. I have skipped it unconditionally for now when tensorrt_rtx is enabled.
  • test_refit_cumsum: cumsum refit errors out on TensorRT-RTX on Windows. Skipped on RTX + Windows, matching the existing skip pattern for the cumsum conversion test added in cba9b75.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

Skip test_refit_one_engine_with_wrong_weightmap on TensorRT-RTX as
refit with wrong weightmap is not supported. Also skip the cumsum
refit test on TensorRT-RTX Windows, matching the existing skip pattern
for the cumsum conversion test.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@meta-cla meta-cla Bot added the cla signed label Apr 16, 2026
@github-actions github-actions Bot added the component: tests Issues re: Tests label Apr 16, 2026
@github-actions github-actions Bot requested a review from lanluo-nvidia April 16, 2026 07:38
@tp5uiuc tp5uiuc changed the title fix(test): skip refit tests that fail on TensorRT-RTX waive(test): skip refit tests that fail on TensorRT-RTX Apr 16, 2026
Copy link
Copy Markdown
Collaborator

@lanluo-nvidia lanluo-nvidia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lanluo-nvidia lanluo-nvidia merged commit f21cc6c into pytorch:main Apr 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants