Skip to content

fix: a few bugs in release/2.12#4270

Merged
lanluo-nvidia merged 2 commits into
release/2.12from
evanli/fix_test_attention_for_2.12
May 16, 2026
Merged

fix: a few bugs in release/2.12#4270
lanluo-nvidia merged 2 commits into
release/2.12from
evanli/fix_test_attention_for_2.12

Conversation

@zewenli98
Copy link
Copy Markdown
Collaborator

@zewenli98 zewenli98 commented May 15, 2026

Description

  1. IAttentionLayer requires strongly typed network. The main branch removed use_explicit_typing but the release/2.12 still has it and use_explicit_typing is False by default.
  2. Skip flash_attention tests on Windows.
  3. Remove the pytorch limitation because I found the dev versions of pytorch 2.12.0 have that limitation but the release version doesn't.
  4. Both L0 dynamo core tests and L1 dynamo core tests on standard TRT Linux runs hlo/ tests on CI workflow, so I removed the duplicate from L0.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 self-assigned this May 15, 2026
@meta-cla meta-cla Bot added the cla signed label May 15, 2026
@github-actions github-actions Bot added the component: tests Issues re: Tests label May 15, 2026
@zewenli98 zewenli98 changed the title fix: test_attention errors targeting release/2.12 fix: a few bugs in release/2.12 May 15, 2026
Copy link
Copy Markdown
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lanluo-nvidia lanluo-nvidia merged commit e196f98 into release/2.12 May 16, 2026
76 of 85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants