-
Notifications
You must be signed in to change notification settings - Fork 383
training ir torchao migration #1006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1006
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 567ee57 with merge base 0ffbf85 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D63859678 |
Summary: Migrate capture_pre_autograd_graph to export_for_training. Differential Revision: D63859678
8397fff to
850d090
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63859678 |
850d090 to
67fa3b4
Compare
Summary: Migrate capture_pre_autograd_graph to export_for_training. We still need to keep capture_pre_autograd_graph call because torch/ao's CI tests uses earlier version of pytorch that does not have export_for_training. Differential Revision: D63859678
|
This pull request was exported from Phabricator. Differential Revision: D63859678 |
test/dtypes/test_uint4.py
Outdated
| import copy | ||
|
|
||
| has_export_for_training = False | ||
| try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be done through a version guard? when does export_for_training start to work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be done through a version guard? when does
export_for_trainingstart to work?
it starts to exist in 2.5.0-rc1. I can make it a version guard. Thanks for the comment!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have some utils here btw:
Lines 25 to 29 in 0ffbf85
| "TORCH_VERSION_AT_LEAST_2_2", | |
| "TORCH_VERSION_AT_LEAST_2_3", | |
| "TORCH_VERSION_AT_LEAST_2_4", | |
| "TORCH_VERSION_AT_LEAST_2_5", | |
| "TORCH_VERSION_AT_LEAST_2_6", |
but notice that it's does not exactly map to current meaning of version, e.g.
TORCH_VERSION_AT_LEAST_2_5 == 2.5.0 or 2.5.0.dev
(instead of 2.5.0 + 2.6.0.dev)
Summary: Migrate capture_pre_autograd_graph to export_for_training. We still need to keep capture_pre_autograd_graph call because torch/ao's CI tests uses earlier version of pytorch that does not have export_for_training. See https://github.com/pytorch/ao/blob/main/.github/workflows/regression_test.yml Differential Revision: D63859678
67fa3b4 to
b5f2869
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63859678 |
Summary: Migrate capture_pre_autograd_graph to export_for_training. We still need to keep capture_pre_autograd_graph call because torch/ao's CI tests uses earlier version of pytorch that does not have export_for_training. See https://github.com/pytorch/ao/blob/main/.github/workflows/regression_test.yml Differential Revision: D63859678
b5f2869 to
ed15f3a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63859678 |
Summary: Migrate capture_pre_autograd_graph to export_for_training. We still need to keep capture_pre_autograd_graph call because torch/ao's CI tests uses earlier version of pytorch that does not have export_for_training. See https://github.com/pytorch/ao/blob/main/.github/workflows/regression_test.yml Differential Revision: D63859678
ed15f3a to
567ee57
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63859678 |
Differential Revision: D63859678 Pull Request resolved: pytorch#1006
Summary: Migrate capture_pre_autograd_graph to export_for_training.
Differential Revision: D63859678