Closed
Conversation
Contributor
Author
|
Stack from ghstack (oldest at bottom): |
vkuzo
added a commit
that referenced
this pull request
Mar 13, 2025
Summary: Switches our MX code to use the new `torch.float8_e8m0fnu` dtype directly where appropriate. This will allow for easier numerical debugging of scales, as we can easily see the numerical values when they are printed. Test Plan: ``` pytest test/prototype/mx_formats/ -s -x ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: e0d0007 ghstack-comment-id: 2721705057 Pull Request resolved: #1882
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1882
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Unrelated FailuresAs of commit ba470ae with merge base 9ef2f06 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
vkuzo
added a commit
that referenced
this pull request
Mar 13, 2025
Summary: Switches our MX code to use the new `torch.float8_e8m0fnu` dtype directly where appropriate. This will allow for easier numerical debugging of scales, as we can easily see the numerical values when they are printed. Test Plan: ``` pytest test/prototype/mx_formats/ -s -x ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 1c0c2ba ghstack-comment-id: 2721705057 Pull Request resolved: #1882
Contributor
Author
|
need to fix CI |
Contributor
Author
|
need to reverse #1608 and get a fresh nightly for this to work, will take a look |
drisspg
approved these changes
Mar 13, 2025
Contributor
Author
|
Looks like this needs something like the inductor changes from pytorch/pytorch#148461 for tests to pass |
Contributor
Author
|
closing in favor of #1966 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Switches our MX code to use the new
torch.float8_e8m0fnudtypedirectly where appropriate. This will allow for easier numerical
debugging of scales, as we can easily see the numerical values when they
are printed.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: