Skip to content

Conversation

@msaroufim
Copy link
Member

@msaroufim msaroufim commented May 24, 2024

Before

(ao) [marksaroufim@devvm17057.vll0 ~/ao (main)]$ pytest test/test_ops.py 

================================================================ test session starts ================================================================
platform linux -- Python 3.10.14, pytest-7.4.0, pluggy-1.4.0
rootdir: /home/marksaroufim/ao
plugins: hypothesis-6.100.5
collected 7 items                                                                                                                                   

test/test_ops.py .......                                                                                                                      [100%]

================================================================= warnings summary ==================================================================
../.local/lib/python3.10/site-packages/torchao/ops.py:12
  /home/marksaroufim/.local/lib/python3.10/site-packages/torchao/ops.py:12: DeprecationWarning: torch.library.impl_abstract was renamed to torch.library.register_fake. Please use that instead; we will remove torch.library.impl_abstract in a future version of PyTorch.
    @torch.library.impl_abstract("torchao::nms")

../.local/lib/python3.10/site-packages/torchao/ops.py:39
  /home/marksaroufim/.local/lib/python3.10/site-packages/torchao/ops.py:39: DeprecationWarning: torch.library.impl_abstract was renamed to torch.library.register_fake. Please use that instead; we will remove torch.library.impl_abstract in a future version of PyTorch.
    @torch.library.impl_abstract("torchao::prepack_fp6_weight")

../.local/lib/python3.10/site-packages/torchao/ops.py:52
  /home/marksaroufim/.local/lib/python3.10/site-packages/torchao/ops.py:52: DeprecationWarning: torch.library.impl_abstract was renamed to torch.library.register_fake. Please use that instead; we will remove torch.library.impl_abstract in a future version of PyTorch.
    @torch.library.impl_abstract("torchao::fp16_to_fp6")

../.local/lib/python3.10/site-packages/torchao/ops.py:77
  /home/marksaroufim/.local/lib/python3.10/site-packages/torchao/ops.py:77: DeprecationWarning: torch.library.impl_abstract was renamed to torch.library.register_fake. Please use that instead; we will remove torch.library.impl_abstract in a future version of PyTorch.
    @torch.library.impl_abstract("torchao::fp16act_fp6weight_linear")

../.local/lib/python3.10/site-packages/torchao/ops.py:98
  /home/marksaroufim/.local/lib/python3.10/site-packages/torchao/ops.py:98: DeprecationWarning: torch.library.impl_abstract was renamed to torch.library.register_fake. Please use that instead; we will remove torch.library.impl_abstract in a future version of PyTorch.
    @torch.library.impl_abstract("torchao::fp6_weight_dequant")

test/test_ops.py::TestOps::test_nms
test/test_ops.py::TestOps::test_nms
test/test_ops.py::TestOps::test_nms
  /home/marksaroufim/.local/lib/python3.10/site-packages/torch/_library/abstract_impl.py:128: UserWarning: create_unbacked_symint is deprecated, please use new_dynamic_size instead
    warnings.warn(

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================================================== 7 passed, 8 warnings in 7.85s ===========================================================
(ao) [marksaroufim@devvm17057.vll0 ~/ao (main)]$ 
(ao) [marksaroufim@devvm17057.vll0 ~/ao (main)]$ 

After

(ao) [marksaroufim@devvm17057.vll0 ~/ao (removecustomopwarnings)]$ pytest test/test_ops.py 
================================================================ test session starts ================================================================
platform linux -- Python 3.10.14, pytest-7.4.0, pluggy-1.4.0
rootdir: /home/marksaroufim/ao
plugins: hypothesis-6.100.5
collected 7 items                                                                                                                                   

test/test_ops.py .......                                                                                                                      [100%]

================================================================= 7 passed in 7.75s =================================================================
(ao) [marksaroufim@devvm17057.vll0 ~/ao (removecustomopwarnings)]$ 

@pytorch-bot
Copy link

pytorch-bot bot commented May 24, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/267

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9821040 with merge base 4a4e86b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 24, 2024
Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@msaroufim msaroufim merged commit 3ed1605 into main May 24, 2024
@msaroufim msaroufim deleted the removecustomopwarnings branch May 24, 2024 01:51
yanbing-j pushed a commit to yanbing-j/ao that referenced this pull request Dec 9, 2024
* Re-enable float16 and int4

* python3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants