Set seed in numeric tests to make them more reliable #2924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2924
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 6e3c6e5 with merge base 71bfccb ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
metascroy
added
topic: not user facing
jerryzh168
reviewed
Sep 2, 2025
| @pytest.mark.parametrize("lead_dim", [(5,), (2, 3)]) | ||
| @pytest.mark.skipif(not is_arm64_mac, reason="requires arm64 mac") | ||
| def test_parq_conversion(dtype, granularity, bit_width, lead_dim): | ||
| torch.manual_seed(0) |
Contributor
There was a problem hiding this comment.
seems OK, but wondering if we migrate to unittest, if this is set automatically in some base class like TestCase.
Contributor
Author
There was a problem hiding this comment.
I'm not sure if it is or not...
jerryzh168
approved these changes
Sep 2, 2025
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets a random seed in the numeric tests to make them deterministic and more reliable.