Skip to content

add bias handling for a_1_128_w_128_128 float8 scaling #3259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Oct 31, 2025
Merged

add bias handling for a_1_128_w_128_128 float8 scaling #3259

merged 24 commits into from
Oct 31, 2025
+20 −5

Conversation

@vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Oct 29, 2025

Summary:

As titled, adds support for bias and a unit test

Test Plan:

pytest test/quantization/quantize_/workflows/float8/test_float8_tensor.py -s -k fp8_linear_variants

Reviewers:

Subscribers:

Tasks:

Tags:

vkuzo added 8 commits October 29, 2025 04:05
@vkuzo
Update
990ef89 
[ghstack-poisoned]
@vkuzo
Update
cce08f0 
[ghstack-poisoned]
@vkuzo
Update
681277a 
[ghstack-poisoned]
@vkuzo
Update
26ade98 
[ghstack-poisoned]
@vkuzo
Update
f76e10b 
[ghstack-poisoned]
@vkuzo
Update
6994e20 
[ghstack-poisoned]
@vkuzo
Update
1aff468 
[ghstack-poisoned]
@vkuzo
Update
f6fa134 
[ghstack-poisoned]
@vkuzo
Copy link
Contributor Author

vkuzo commented Oct 29, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

vkuzo added a commit that referenced this pull request Oct 29, 2025
@vkuzo
add bias handling for a_1_128_w_128_128 float8 scaling
db72466 
Summary:

As titled, adds support for bias and a unit test

Test Plan:

```
pytest test/quantization/quantize_/workflows/float8/test_float8_tensor.py -s -k fp8_linear_variants
```

Reviewers:

Subscribers:

Tasks:

Tags:
ghstack-source-id: 07b623e
ghstack-comment-id: 3463298384
Pull-Request: #3259
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 29, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3259

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@vkuzo vkuzo mentioned this pull request Oct 29, 2025
Merged
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 29, 2025
This was referenced Oct 29, 2025
Merged
Merged
@vkuzo
Update
1911212 
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Oct 29, 2025
@vkuzo
add bias handling for a_1_128_w_128_128 float8 scaling
19b346d 
Summary:

As titled, adds support for bias and a unit test

Test Plan:

```
pytest test/quantization/quantize_/workflows/float8/test_float8_tensor.py -s -k fp8_linear_variants
```

Reviewers:

Subscribers:

Tasks:

Tags:
ghstack-source-id: a5a2461
ghstack-comment-id: 3463298384
Pull-Request: #3259
@vkuzo
Update
9ec8ce1 
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Oct 29, 2025
@vkuzo
add bias handling for a_1_128_w_128_128 float8 scaling
3f904ed 
Summary:

As titled, adds support for bias and a unit test

Test Plan:

```
pytest test/quantization/quantize_/workflows/float8/test_float8_tensor.py -s -k fp8_linear_variants
```

Reviewers:

Subscribers:

Tasks:

Tags:
ghstack-source-id: 50f7a26
ghstack-comment-id: 3463298384
Pull-Request: #3259
@vkuzo vkuzo added the topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories) label Oct 30, 2025
vkuzo added 3 commits October 30, 2025 04:17
@vkuzo
Update
57b8876 
[ghstack-poisoned]
@vkuzo
Update
1161f7f 
[ghstack-poisoned]
@vkuzo
Update
c5be7c0 
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Oct 30, 2025
@vkuzo
add bias handling for a_1_128_w_128_128 float8 scaling
6d9a732 
Summary:

As titled, adds support for bias and a unit test

Test Plan:

```
pytest test/quantization/quantize_/workflows/float8/test_float8_tensor.py -s -k fp8_linear_variants
```

Reviewers:

Subscribers:

Tasks:

Tags:
ghstack-source-id: e9bf640
ghstack-comment-id: 3463298384
Pull-Request: #3259
vkuzo added 2 commits October 30, 2025 04:18
@vkuzo
Update
00c6bbb 
[ghstack-poisoned]
@vkuzo
Update
d40ec7c 
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Oct 30, 2025
@vkuzo
add bias handling for a_1_128_w_128_128 float8 scaling
cc4b409 
Summary:

As titled, adds support for bias and a unit test

Test Plan:

```
pytest test/quantization/quantize_/workflows/float8/test_float8_tensor.py -s -k fp8_linear_variants
```

Reviewers:

Subscribers:

Tasks:

Tags:
ghstack-source-id: e9bf640
ghstack-comment-id: 3463298384
Pull-Request: #3259
vkuzo added 2 commits October 30, 2025 04:41
@vkuzo
Update
ce5a8eb 
[ghstack-poisoned]
@vkuzo
Update
be5a9bb 
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Oct 30, 2025
@vkuzo
add bias handling for a_1_128_w_128_128 float8 scaling
6452a16 
Summary:

As titled, adds support for bias and a unit test

Test Plan:

```
pytest test/quantization/quantize_/workflows/float8/test_float8_tensor.py -s -k fp8_linear_variants
```

Reviewers:

Subscribers:

Tasks:

Tags:
ghstack-source-id: d603372
ghstack-comment-id: 3463298384
Pull-Request: #3259
vkuzo added 2 commits October 30, 2025 12:50
@vkuzo
Update
6a3684b 
[ghstack-poisoned]
@vkuzo
Update
1d4a2f7 
[ghstack-poisoned]
@vkuzo vkuzo mentioned this pull request Oct 30, 2025
Open
@vkuzo vkuzo requested a review from jerryzh168 October 30, 2025 19:56
jerryzh168
jerryzh168 reviewed Oct 30, 2025
View reviewed changes
test/quantization/quantize_/workflows/float8/test_float8_tensor.py

class ToyLinearModel(torch.nn.Module):
def __init__(self, in_features, out_features):
def __init__(self, in_features, out_features, bias):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: feels like bias is a bit confusing (since it can be a flag v.s. Tensor), even though it's used official in nn.Linear, maybe use has_bias as the other tests are doing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, let me do that in a future PR

vkuzo added 4 commits October 31, 2025 06:26
@vkuzo
Update
6c087b4 
[ghstack-poisoned]
@vkuzo
Update
4de79c9 
[ghstack-poisoned]
@vkuzo
Update
c4769a6 
[ghstack-poisoned]
@vkuzo
Update
eb95772 
[ghstack-poisoned]
@vkuzo vkuzo mentioned this pull request Oct 31, 2025
Open
@vkuzo
Update
76671f9 
[ghstack-poisoned]
@vkuzo vkuzo changed the base branch from gh/vkuzo/158/head to main October 31, 2025 19:43
@vkuzo vkuzo merged commit f856d36 into main Oct 31, 2025
31 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerryzh168 jerryzh168 jerryzh168 approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vkuzo @jerryzh168