Skip to content

Conversation

@vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Oct 30, 2025

Summary:

For now, we just care about bf16 output. We can add fp32 and a flag to
control it later, if needed.

Test Plan:

pytest test/quantization/quantize_/workflows/float8/test_float8_tensor.py -s -k fp8_linear_variants -x

Reviewers:

Subscribers:

Tasks:

Tags:

vkuzo added 20 commits October 29, 2025 04:05
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@vkuzo
Copy link
Contributor Author

vkuzo commented Oct 30, 2025

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3265

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit c877d67 with merge base f856d36 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 30, 2025
vkuzo added a commit that referenced this pull request Oct 30, 2025
Summary:

For now, we just care about bf16 output.  We can add fp32 and a flag to
control it later, if needed.

Test Plan:

```
pytest test/quantization/quantize_/workflows/float8/test_float8_tensor.py -s -k fp8_linear_variants -x
```

Reviewers:

Subscribers:

Tasks:

Tags:
ghstack-source-id: b3c443c
ghstack-comment-id: 3469836810
Pull-Request: #3265
@vkuzo vkuzo requested a review from danielvegamyhre October 30, 2025 19:56
@vkuzo vkuzo added the topic: bug fix Use this tag for PRs that fix bugs label Oct 31, 2025
vkuzo added 2 commits October 31, 2025 06:26
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Oct 31, 2025
Summary:

For now, we just care about bf16 output.  We can add fp32 and a flag to
control it later, if needed.

Test Plan:

```
pytest test/quantization/quantize_/workflows/float8/test_float8_tensor.py -s -k fp8_linear_variants -x
```

Reviewers:

Subscribers:

Tasks:

Tags:
ghstack-source-id: f00cd47
ghstack-comment-id: 3469836810
Pull-Request: #3265
vkuzo added 3 commits October 31, 2025 09:59
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Oct 31, 2025
Summary:

For now, we just care about bf16 output.  We can add fp32 and a flag to
control it later, if needed.

Test Plan:

```
pytest test/quantization/quantize_/workflows/float8/test_float8_tensor.py -s -k fp8_linear_variants -x
```

Reviewers:

Subscribers:

Tasks:

Tags:
ghstack-source-id: 8a63a04
ghstack-comment-id: 3469836810
Pull-Request: #3265
vkuzo added 3 commits October 31, 2025 12:43
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@vkuzo vkuzo changed the base branch from gh/vkuzo/159/head to main October 31, 2025 19:44
Copy link
Contributor

@danielvegamyhre danielvegamyhre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Btw in my benchmarks I found the torch._scaled_mm cutlass kernel for blockwise gemms to be much faster than the triton kernels. This was a few months ago, you can run the benchmarks scripts in this dir if you want: https://github.com/pytorch/ao/tree/main/benchmarks/prototype/blockwise_fp8_training

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: bug fix Use this tag for PRs that fix bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants