Move dyn_int8_act_int4_wei_cpu_layout to prototype/dtypes #3299
+434
−369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3299
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 12 PendingAs of commit 4706b67 with merge base 6259e98 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
jainapurva
added
the
topic: for developers
17 tasks
jainapurva
force-pushed
the
move_dyn_int8
branch
from
a4df015 to
d3db93e
Compare
jerryzh168
reviewed
Nov 7, 2025
jerryzh168
approved these changes
Nov 7, 2025
andrewor14
approved these changes
Nov 7, 2025
Contributor
andrewor14
left a comment
andrewor14
left a comment
There was a problem hiding this comment.
Thanks, just left some small nits about testing
| warnings.simplefilter("always") # Ensure all warnings are captured | ||
| assert any( | ||
| issubclass(warning.category, DeprecationWarning) | ||
| and "CutlassInt4PackedLayout" in str(warning.message) |
Contributor
There was a problem hiding this comment.
can we merge these tests to do this in a loop or reuse the code somehow?
| ] | ||
| for mod in modules_to_clear: | ||
| if mod in sys.modules: | ||
| del sys.modules[mod] |
Contributor
There was a problem hiding this comment.
maybe easier to just reset the warnings like this:
Line 46 in 6259e98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request moves Int8DynamicActInt4WeightCPULayout and its implementation from torchao/dtypes/uintx/dyn_int8_act_int4_wei_cpu_layout.py to torchao/prototype/dtypes/uintx/dyn_int8_act_int4_wei_cpu_layout.py, and exposed it via torchao.prototype.dtypes while maintaining BC at torchao.prototype.dtypes.uintx with a deprecation warning for future torchao release.
Updates API documentation to reflect the changes
Reference Issue: #2752