Skip to content

support fp8 scaled_embedding_bag pattern match #3406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Xia-Weiwen merged 3 commits into from
Dec 11, 2025
Merged

support fp8 scaled_embedding_bag pattern match #3406

Xia-Weiwen merged 3 commits into from
Dec 11, 2025
+181 −0

Conversation

@shiyang-weng
Copy link
Contributor

@shiyang-weng shiyang-weng commented Dec 1, 2025 •
edited
Loading

Fuse dq + embeddingbag => _scaled_embedding_bag

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 1, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3406

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f6519e3 with merge base 4f5bc7a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 1, 2025
@shiyang-weng shiyang-weng marked this pull request as draft December 1, 2025 01:48
@shiyang-weng
Copy link
Contributor Author

shiyang-weng commented Dec 1, 2025

@Xia-Weiwen @mingfeima Could you help review this PR?

@shiyang-weng
Copy link
Contributor Author

shiyang-weng commented Dec 1, 2025

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Dec 1, 2025
Xia-Weiwen
Xia-Weiwen approved these changes Dec 4, 2025
View reviewed changes
Copy link
Collaborator

@Xia-Weiwen Xia-Weiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

shiyang-weng and others added 2 commits December 4, 2025 15:10
@shiyang-weng @Xia-Weiwen
Update torchao/quantization/pt2e/inductor_passes/x86.py
49bc738 
Co-authored-by: Xia Weiwen <xia.weiwen@hotmail.com>
@shiyang-weng
refine code
f6519e3
@Xia-Weiwen Xia-Weiwen requested a review from jerryzh168 December 5, 2025 01:36
@Xia-Weiwen Xia-Weiwen marked this pull request as ready for review December 5, 2025 01:36
@shiyang-weng shiyang-weng mentioned this pull request Dec 8, 2025
Draft
@shiyang-weng
Copy link
Contributor Author

shiyang-weng commented Dec 10, 2025

@jerryzh168 Could you help review

@Xia-Weiwen Xia-Weiwen merged commit 3da4862 into pytorch:main Dec 11, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerryzh168 jerryzh168 jerryzh168 approved these changes

@Xia-Weiwen Xia-Weiwen Xia-Weiwen approved these changes

Assignees

No one assigned

Labels

ciflow/rocm CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shiyang-weng @jerryzh168 @Xia-Weiwen