[bc-breaking] delete old smoothquant implementation#3495
Merged
Conversation
Contributor
Author
|
Stack from ghstack (oldest at bottom): |
vkuzo
added a commit
that referenced
this pull request
Dec 16, 2025
Summary: Deleting `torchao.smoothquant` as it is outdated. The smoothquant implementation in `torchao.prototype.smoothquant` is the best one to use. Breaking BC without a deprecation process as we don't know of anyone who is still using this. Test Plan: CI Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 4a05c54 ghstack-comment-id: 3660936117 Pull-Request: #3495
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3495
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 18f8692 with merge base b9e5780 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
vkuzo
added a commit
that referenced
this pull request
Dec 16, 2025
Summary: Deleting `torchao.smoothquant` as it is outdated. The smoothquant implementation in `torchao.prototype.smoothquant` is the best one to use. Breaking BC without a deprecation process as we don't know of anyone who is still using this. Test Plan: CI Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 6161a37 ghstack-comment-id: 3660936117 Pull-Request: #3495
vkuzo
added a commit
that referenced
this pull request
Dec 16, 2025
Summary: Deleting `torchao.smoothquant` as it is outdated. The smoothquant implementation in `torchao.prototype.smoothquant` is the best one to use. Breaking BC without a deprecation process as we don't know of anyone who is still using this. Test Plan: CI Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 90cc40a ghstack-comment-id: 3660936117 Pull-Request: #3495
jerryzh168
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Deleting
torchao.smoothquantas it is outdated and to reduce confusion. The smoothquantimplementation in
torchao.prototype.smoothquantis the best one touse.
Breaking BC without a deprecation process as we don't know of anyone who is
still using this.
Test Plan: CI
Reviewers:
Subscribers:
Tasks:
Tags: