Skip to content

[mxfp8] bug fix and test updates related to new triton_calculate_scale param#3522

Merged
danielvegamyhre merged 2 commits intomainfrom
dvm20
Dec 24, 2025
Merged

[mxfp8] bug fix and test updates related to new triton_calculate_scale param#3522
danielvegamyhre merged 2 commits intomainfrom
dvm20

Conversation

@danielvegamyhre
Copy link
Copy Markdown
Contributor

@danielvegamyhre danielvegamyhre commented Dec 21, 2025

Tests

  • pytest test/prototype/mx_formats/test_kernels.py verified whole test suite is passing locally this time

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Dec 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3522

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job, 1 Unrelated Failure

As of commit dca46b4 with merge base 7035fb7 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 21, 2025
@danielvegamyhre danielvegamyhre changed the title [mxfp8] bug fix in new triton_calculate_scale param [mxfp8] bug fix and test updates related to new triton_calculate_scale param Dec 21, 2025
@danielvegamyhre danielvegamyhre added mx topic: bug fix Use this tag for PRs that fix bugs labels Dec 21, 2025
@danielvegamyhre
Copy link
Copy Markdown
Contributor Author

cc @drisspg for review


def triton_to_mxfp8_dim1_reference(
x_hp: torch.Tensor, block_size
x_hp: torch.Tensor,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we can we should try to have 1 default arg at the top user facing and then not populate for inner funcs should help with these types of bug

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the launcher functions do have defaults for scaling_mode (rceil) that are passed in to the actual kernels. (let me know if i misunderstood your comment)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh you mean in this torch reference impl? i will add a default.

@danielvegamyhre danielvegamyhre merged commit 25418fd into main Dec 24, 2025
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. mx topic: bug fix Use this tag for PRs that fix bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants