[mxfp8 moe training] integrate cuda kernel for 'groups along M scale blocked layout'#3556
Merged
danielvegamyhre merged 1 commit intomainfrom Dec 31, 2025
Merged
[mxfp8 moe training] integrate cuda kernel for 'groups along M scale blocked layout'#3556danielvegamyhre merged 1 commit intomainfrom
danielvegamyhre merged 1 commit intomainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3556
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
2fe1f60 to
f1bf15c
Compare
drisspg
approved these changes
Dec 30, 2025
7a12730 to
5bfa927
Compare
f1bf15c to
d863628
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
pytest test/prototype/moe_training/test_scaled_grouped_mm.pyBenchmarks for autograd func fwd + bwd (dynamic mxfp8 quantization + mxfp8 grouped GEMM)
This change helps across all shapes, but especially for the smaller dsv3 model (16b) where the quantization kernels are a larger % of overall runtime
Before:
After: