Skip to content

Fix fake fusion for convolutions without bias (#3353)#3633

Merged
jerryzh168 merged 1 commit intomainfrom
pr-3353
Jan 15, 2026
Merged

Fix fake fusion for convolutions without bias (#3353)#3633
jerryzh168 merged 1 commit intomainfrom
pr-3353

Conversation

@jerryzh168
Copy link
Copy Markdown
Contributor

Summary:

Fix AttributeError when performing fake fusion on convolution layers without bias by creating a zero-filled bias parameter instead of attempting to access requires_grad on None.

Reviewed By: jerryzh168

Differential Revision: D87356763

Summary:

Fix `AttributeError` when performing fake fusion on convolution layers without bias by creating a zero-filled bias parameter instead of attempting to access requires_grad on None.

Reviewed By: jerryzh168

Differential Revision: D87356763
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Jan 14, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3633

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 9a92862 with merge base 985d970 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 14, 2026
@jerryzh168
Copy link
Copy Markdown
Contributor Author

jerryzh168 commented Jan 14, 2026

fixing ruff errors from #3353

cc @balakrishnanv

@jerryzh168 jerryzh168 added the topic: bug fix Use this tag for PRs that fix bugs label Jan 14, 2026
@jerryzh168 jerryzh168 merged commit ac1c41d into main Jan 15, 2026
21 of 23 checks passed
jcaip pushed a commit that referenced this pull request Jan 22, 2026
Summary:

Fix `AttributeError` when performing fake fusion on convolution layers without bias by creating a zero-filled bias parameter instead of attempting to access requires_grad on None.

Reviewed By: jerryzh168

Differential Revision: D87356763

Co-authored-by: Bala Varadarajan <balakv@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: bug fix Use this tag for PRs that fix bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants