Fix zero-point handling for packed_weight_inputs in INT8#3685
Merged
Xia-Weiwen merged 1 commit intopytorch:mainfrom Jan 26, 2026
Merged
Fix zero-point handling for packed_weight_inputs in INT8#3685Xia-Weiwen merged 1 commit intopytorch:mainfrom
Xia-Weiwen merged 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3685
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 50ec984 with merge base 2a8714f ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
Author
|
@Xia-Weiwen Could you please help me review this PR. Thanks! |
Xia-Weiwen
reviewed
Jan 22, 2026
Collaborator
Xia-Weiwen
left a comment
Xia-Weiwen
left a comment
There was a problem hiding this comment.
Thanks for the fix. Can you also add a test case? Thanks
Xia-Weiwen
added
the
module: not user facing
Xia-Weiwen
approved these changes
Jan 26, 2026
Collaborator
|
CI failure is CUDA only, unrelated to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INT8 requires zero-point, so add conditional zero-point handling for packed_weight_inputs.