[mx] Fix: pass scaling_mode parameter to triton_to_mxfp8_dim1#3686
Merged
danielvegamyhre merged 1 commit intopytorch:mainfrom Mar 5, 2026
Merged
[mx] Fix: pass scaling_mode parameter to triton_to_mxfp8_dim1#3686danielvegamyhre merged 1 commit intopytorch:mainfrom
danielvegamyhre merged 1 commit intopytorch:mainfrom
Conversation
When triton_to_mxfp8_dim1() was called from _to_mxfp8_dim1_kernel_wrapper(), the scale_calculation_mode parameter was not passed, resulting in incorrect default value. Signed-off-by: Ula Golowicz <urszula.golowicz@intel.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3686
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New FailuresAs of commit 969310d with merge base 2a8714f ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Affected tests:Test commandValidate with: pytest test/prototype/mx_formats/test_mx_linear.py -sv -k "test_linear_eager_vs_hp and FLOOR and TRITON" |
|
This PR is part of #2326 effort. |
liangan1
added
ciflow/xpu
Contributor
|
hi @ugolowic i missed this somehow, do you still want to land this? |
Contributor
Author
|
@danielvegamyhre, yes, I do |
Contributor
|
test failures were unrelated, landed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the
scaling_modeparameter was not being forwarded from_to_mxfp8_dim1_kernel_wrappertotriton_to_mxfp8_dim1, causing the function to always default to "rceil" scaling mode.