Skip to content

Deleted tensor_core_tiled_layout.cu#3722

Merged
andrewor14 merged 6 commits intomainfrom
gh/howardzhang-cv/6/head
Jan 28, 2026
Merged

Deleted tensor_core_tiled_layout.cu#3722
andrewor14 merged 6 commits intomainfrom
gh/howardzhang-cv/6/head

Conversation

@howardzhang-cv
Copy link
Copy Markdown
Contributor

@howardzhang-cv howardzhang-cv commented Jan 26, 2026

Stack from ghstack (oldest at bottom):

Summary: Deleted tensor_core_tiled_layout.cu
Deleted op registrations in ops.py
Deleted corresponding tests in test_ops.py
Deleted references in READMEs and setup.py

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D91500687

[ghstack-poisoned]
[ghstack-poisoned]
howardzhang-cv added a commit that referenced this pull request Jan 26, 2026
Summary: Deleted tensor_core_tiled_layout.cu
Deleted op registrations in ops.py
Deleted corresponding tests in test_ops.py
Deleted references in READMEs and setup.py

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
ghstack-source-id: b8b6326
Pull-Request: #3722
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Jan 26, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3722

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 13a1468 with merge base ef944d2 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 26, 2026
@howardzhang-cv
Copy link
Copy Markdown
Contributor Author

@howardzhang-cv has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@howardzhang-cv howardzhang-cv added module: bc-breaking Use this tag if this PR breaks backward compatibility module: deprecation Use this tag if this PR deprecates a feature labels Jan 26, 2026
[ghstack-poisoned]
howardzhang-cv added a commit that referenced this pull request Jan 26, 2026
Summary: Deleted tensor_core_tiled_layout.cu
Deleted op registrations in ops.py
Deleted corresponding tests in test_ops.py
Deleted references in READMEs and setup.py

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
ghstack-source-id: 9e579ac
Pull-Request: #3722
@howardzhang-cv
Copy link
Copy Markdown
Contributor Author

@howardzhang-cv has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[ghstack-poisoned]
howardzhang-cv added a commit that referenced this pull request Jan 26, 2026
Summary: Deleted tensor_core_tiled_layout.cu
Deleted op registrations in ops.py
Deleted corresponding tests in test_ops.py
Deleted references in READMEs and setup.py

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
ghstack-source-id: 406bed6
Pull-Request: #3722
@howardzhang-cv
Copy link
Copy Markdown
Contributor Author

@howardzhang-cv has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jerryzh168
Copy link
Copy Markdown
Contributor

jerryzh168 commented Jan 26, 2026

for context, we are deleting this for (1) better ABI (2) tensor core tiled layout is not as important as before as we have new hardwares, also dequantize op is not used in new stack: https://github.com/pytorch/ao/blob/main/torchao/quantization/quantize_/workflows/int4/int4_tile_packed_to_4d_tensor.py

Copy link
Copy Markdown
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg, please see comment inline

[ghstack-poisoned]
howardzhang-cv added a commit that referenced this pull request Jan 26, 2026
Summary: Deleted tensor_core_tiled_layout.cu
Deleted op registrations in ops.py
Deleted corresponding tests in test_ops.py
Deleted references in READMEs and setup.py

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
ghstack-source-id: 22eb5e9
Pull-Request: #3722
@howardzhang-cv
Copy link
Copy Markdown
Contributor Author

@howardzhang-cv has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@howardzhang-cv howardzhang-cv changed the base branch from gh/howardzhang-cv/6/base to main January 27, 2026 19:40
@howardzhang-cv
Copy link
Copy Markdown
Contributor Author

@howardzhang-cv has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@andrewor14
Copy link
Copy Markdown
Contributor

Looks great to me too! Thanks, merging this

@andrewor14 andrewor14 merged commit 59f7697 into main Jan 28, 2026
55 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: bc-breaking Use this tag if this PR breaks backward compatibility module: deprecation Use this tag if this PR deprecates a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants