Make _emulated_mxfp8_scaled_grouped_mm_2d_2d torch.compile compatible#3906
Merged
danielvegamyhre merged 2 commits intopytorch:mainfrom Feb 19, 2026
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3906
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1fd57f5 with merge base 396d78b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
this is much better, thanks! |
Contributor
Author
|
Looks like CI is blocked by PR label check? |
danielvegamyhre
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_emulated_mxfp8_scaled_grouped_mm_2d_2dwith vectorized ops, removing the@torch.compiler.disabledecoratoroffs.tolist()and a Python loop with data-dependent control flow, which preventedtorch.compilefrom tracing through the emulated MXFP8 wgrad pathpytest.skipforEMULATED+use_compile=Trueintest_mxfp8_grouped_gemm_with_dq_fwd_bwd