Skip to content

Unskip TestSemiStructuredSparse.test_sparse (#4064)#4064

Merged
meta-codesync[bot] merged 1 commit intopytorch:mainfrom
bbeckca:export-D96172407
Mar 17, 2026
Merged

Unskip TestSemiStructuredSparse.test_sparse (#4064)#4064
meta-codesync[bot] merged 1 commit intopytorch:mainfrom
bbeckca:export-D96172407

Conversation

@bbeckca
Copy link
Copy Markdown
Contributor

@bbeckca bbeckca commented Mar 12, 2026

Summary:

What: Remove temporary skip on TestSemiStructuredSparse.test_sparse

Why: The existing TorchAO sparsity test now passes locally again on the CUDA cuSPARSELt path, so the temporary skip is no longer needed.

Reviewed By: RandySheriff

Differential Revision: D96172407

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Mar 12, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4064

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d1971cb with merge base 960f307 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 12, 2026
bbeckca added a commit to bbeckca/ao that referenced this pull request Mar 12, 2026
Summary:

What: Remove temporary skip on `TestSemiStructuredSparse.test_sparse`

Why: The existing TorchAO sparsity test now passes locally again on the CUDA cuSPARSELt path, so the temporary skip is no longer needed.

Differential Revision: D96172407
@bbeckca
Copy link
Copy Markdown
Contributor Author

bbeckca commented Mar 16, 2026

@pytorchbot label "topic: not user facing"

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Mar 16, 2026

Didn't find following labels among repository labels: topic: not user facing

@bbeckca
Copy link
Copy Markdown
Contributor Author

bbeckca commented Mar 16, 2026

@pytorchbot label "module: not user facing"

@pytorch-bot pytorch-bot bot added the module: not user facing Use this tag if you don't want this PR to show up in release notes label Mar 16, 2026
@bbeckca
Copy link
Copy Markdown
Contributor Author

bbeckca commented Mar 16, 2026

Note: The failures I'm seeing don't appear related to changes made in this diff

test/quantization/pt2e/test_x86inductor_fusion.py::TestDynamicPatternMatcher::test_fp8_q_attention_block - AssertionError: Scalars are not equal!

test/quantization/pt2e/test_x86inductor_fusion.py::TestDynamicPatternMatcher::test_q_attention_block - AssertionError: Scalars are not equal!

bbeckca added a commit to bbeckca/ao that referenced this pull request Mar 16, 2026
Summary:

What: Remove temporary skip on `TestSemiStructuredSparse.test_sparse`

Why: The existing TorchAO sparsity test now passes locally again on the CUDA cuSPARSELt path, so the temporary skip is no longer needed.

Reviewed By: RandySheriff

Differential Revision: D96172407
@meta-codesync meta-codesync bot changed the title Unskip TestSemiStructuredSparse.test_sparse Unskip TestSemiStructuredSparse.test_sparse (#4064) Mar 16, 2026
bbeckca added a commit to bbeckca/ao that referenced this pull request Mar 16, 2026
Summary:

What: Remove temporary skip on `TestSemiStructuredSparse.test_sparse`

Why: The existing TorchAO sparsity test now passes locally again on the CUDA cuSPARSELt path, so the temporary skip is no longer needed.

Reviewed By: RandySheriff

Differential Revision: D96172407
@meta-codesync
Copy link
Copy Markdown

meta-codesync bot commented Mar 16, 2026

@bbeckca has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96172407.

bbeckca added a commit to bbeckca/ao that referenced this pull request Mar 16, 2026
Summary:

What: Remove temporary skip on `TestSemiStructuredSparse.test_sparse`

Why: The existing TorchAO sparsity test now passes locally again on the CUDA cuSPARSELt path, so the temporary skip is no longer needed.

Reviewed By: RandySheriff

Differential Revision: D96172407
bbeckca added a commit to bbeckca/ao that referenced this pull request Mar 16, 2026
Summary:

What: Remove temporary skip on `TestSemiStructuredSparse.test_sparse`

Why: The existing TorchAO sparsity test now passes locally again on the CUDA cuSPARSELt path, so the temporary skip is no longer needed.

Reviewed By: RandySheriff

Differential Revision: D96172407
bbeckca added a commit to bbeckca/ao that referenced this pull request Mar 16, 2026
Summary:
Pull Request resolved: pytorch#4064

What: Remove temporary skip on `TestSemiStructuredSparse.test_sparse`

Why: The existing TorchAO sparsity test now passes locally again on the CUDA cuSPARSELt path, so the temporary skip is no longer needed.

Reviewed By: RandySheriff

Differential Revision: D96172407
bbeckca added a commit to bbeckca/ao that referenced this pull request Mar 16, 2026
Summary:
Pull Request resolved: pytorch#4064

What: Remove temporary skip on `TestSemiStructuredSparse.test_sparse`

Why: The existing TorchAO sparsity test now passes locally again on the CUDA cuSPARSELt path, so the temporary skip is no longer needed.

Reviewed By: RandySheriff

Differential Revision: D96172407
bbeckca added a commit to bbeckca/ao that referenced this pull request Mar 16, 2026
Summary:

What: Remove temporary skip on `TestSemiStructuredSparse.test_sparse`

Why: The existing TorchAO sparsity test now passes locally again on the CUDA cuSPARSELt path, so the temporary skip is no longer needed.

Reviewed By: RandySheriff

Differential Revision: D96172407
Summary:
Pull Request resolved: pytorch#4064

What: Remove temporary skip on `TestSemiStructuredSparse.test_sparse`

Why: The existing TorchAO sparsity test now passes locally again on the CUDA cuSPARSELt path, so the temporary skip is no longer needed.

Reviewed By: RandySheriff

Differential Revision: D96172407
@jcaip jcaip self-requested a review March 16, 2026 17:12
bbeckca added a commit to bbeckca/ao that referenced this pull request Mar 17, 2026
Summary:

What: Remove temporary skip on `TestSemiStructuredSparse.test_sparse`

Why: The existing TorchAO sparsity test now passes locally again on the CUDA cuSPARSELt path, so the temporary skip is no longer needed.

Reviewed By: RandySheriff

Differential Revision: D96172407
bbeckca added a commit to bbeckca/ao that referenced this pull request Mar 17, 2026
Summary:
Pull Request resolved: pytorch#4064

What: Remove temporary skip on `TestSemiStructuredSparse.test_sparse`

Why: The existing TorchAO sparsity test now passes locally again on the CUDA cuSPARSELt path, so the temporary skip is no longer needed.

Reviewed By: RandySheriff

Differential Revision: D96172407
@meta-codesync meta-codesync bot merged commit 637c4ac into pytorch:main Mar 17, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported module: not user facing Use this tag if you don't want this PR to show up in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants