Fix test_sparse_api failures for builds without hipSPARSELt (#4125)#4125
Merged
jerryzh168 merged 1 commit intopytorch:mainfrom Mar 24, 2026
Merged
Fix test_sparse_api failures for builds without hipSPARSELt (#4125)#4125jerryzh168 merged 1 commit intopytorch:mainfrom
jerryzh168 merged 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4125
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit f8da8fd with merge base bca91b0 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Contributor
Author
|
@pytorchbot label "module: not user facing" |
pytorch-bot
Bot
added
the
module: not user facing
meta-codesync
Bot
changed the title
bbeckca
added a commit
to bbeckca/ao
that referenced
this pull request
Mar 20, 2026
…4125) Summary: What: Add a guard in test/sparsity/test_sparse_api.py so tests that depend on `hipSPARSELt` only run when the backend is available. Why: These tests currently fail on environments without hipSPARSELt, for example OSS AO nightly. Since the functionality is environment dependent, these test should be conditionally skipped. https://fburl.com/9fpszdqg ``` FAILED test/sparsity/test_sparse_api.py::TestSemiStructuredSparse::test_sparse - RuntimeError: hipSPARSELt not supported on your machine. ``` Differential Revision: D97540060
bbeckca
force-pushed
the
export-D97540060
branch
2 times, most recently
from
671a601 to
b85bedf
Compare
bbeckca
added a commit
to bbeckca/ao
that referenced
this pull request
Mar 23, 2026
…4125) Summary: What: Add a guard in test/sparsity/test_sparse_api.py so tests that depend on `hipSPARSELt` only run when the backend is available. Why: These tests currently fail on environments without hipSPARSELt, for example OSS AO nightly. Since the functionality is environment dependent, these test should be conditionally skipped. https://fburl.com/9fpszdqg ``` FAILED test/sparsity/test_sparse_api.py::TestSemiStructuredSparse::test_sparse - RuntimeError: hipSPARSELt not supported on your machine. ``` Differential Revision: D97540060
jcaip
reviewed
Mar 23, 2026
| sparsify_(model, semi_sparse_weight()) | ||
| sparse_result = model(input) | ||
|
|
||
| if compile: |
Contributor
There was a problem hiding this comment.
why are we deleting the compile test?
Contributor
Author
There was a problem hiding this comment.
We're not setting any @common_utils.parametrize("compile", [True, False]) so I don't think this path was being used. Would you prefer we enable it as opposed to removing?
Contributor
There was a problem hiding this comment.
Oh I see, hmm can we add @common_utils.parametrize("compile", [True, False]) to the test as well then?
Contributor
Author
There was a problem hiding this comment.
Update: Aligned offline. @jcaip will update compile test in follow up diff.
bbeckca
added a commit
to bbeckca/ao
that referenced
this pull request
Mar 23, 2026
…4125) Summary: What: Add a guard in test/sparsity/test_sparse_api.py so tests that depend on `hipSPARSELt` only run when the backend is available. Why: These tests currently fail on environments without hipSPARSELt, for example OSS AO nightly. Since the functionality is environment dependent, these test should be conditionally skipped. https://fburl.com/9fpszdqg ``` FAILED test/sparsity/test_sparse_api.py::TestSemiStructuredSparse::test_sparse - RuntimeError: hipSPARSELt not supported on your machine. ``` Differential Revision: D97540060
bbeckca
force-pushed
the
export-D97540060
branch
from
b85bedf to
b098679
Compare
bbeckca
added a commit
to bbeckca/ao
that referenced
this pull request
Mar 23, 2026
…4125) Summary: Pull Request resolved: pytorch#4125 What: Add a guard in test/sparsity/test_sparse_api.py so tests that depend on `hipSPARSELt` only run when the backend is available. Why: These tests currently fail on environments without hipSPARSELt, for example OSS AO nightly. Since the functionality is environment dependent, these test should be conditionally skipped. https://fburl.com/9fpszdqg ``` FAILED test/sparsity/test_sparse_api.py::TestSemiStructuredSparse::test_sparse - RuntimeError: hipSPARSELt not supported on your machine. ``` Differential Revision: D97540060
bbeckca
force-pushed
the
export-D97540060
branch
from
b098679 to
1bd983f
Compare
bbeckca
added a commit
to bbeckca/ao
that referenced
this pull request
Mar 23, 2026
…4125) Summary: What: Add a guard in test/sparsity/test_sparse_api.py so tests that depend on `hipSPARSELt` only run when the backend is available. Why: These tests currently fail on environments without hipSPARSELt, for example OSS AO nightly. Since the functionality is environment dependent, these test should be conditionally skipped. https://fburl.com/9fpszdqg ``` FAILED test/sparsity/test_sparse_api.py::TestSemiStructuredSparse::test_sparse - RuntimeError: hipSPARSELt not supported on your machine. ``` Differential Revision: D97540060
bbeckca
force-pushed
the
export-D97540060
branch
from
1bd983f to
fb78fd6
Compare
bbeckca
added a commit
to bbeckca/ao
that referenced
this pull request
Mar 23, 2026
…4125) Summary: What: Add a guard in test/sparsity/test_sparse_api.py so tests that depend on `hipSPARSELt` only run when the backend is available. Why: These tests currently fail on environments without hipSPARSELt, for example OSS AO nightly. Since the functionality is environment dependent, these test should be conditionally skipped. https://fburl.com/9fpszdqg ``` FAILED test/sparsity/test_sparse_api.py::TestSemiStructuredSparse::test_sparse - RuntimeError: hipSPARSELt not supported on your machine. ``` Differential Revision: D97540060
bbeckca
force-pushed
the
export-D97540060
branch
from
fb78fd6 to
9ce4bad
Compare
…4125) Summary: What: Add a guard in test/sparsity/test_sparse_api.py so tests that depend on `hipSPARSELt` only run when the backend is available. Why: These tests currently fail on environments without hipSPARSELt, for example OSS AO nightly. Since the functionality is environment dependent, these test should be conditionally skipped. https://fburl.com/9fpszdqg ``` FAILED test/sparsity/test_sparse_api.py::TestSemiStructuredSparse::test_sparse - RuntimeError: hipSPARSELt not supported on your machine. ``` Differential Revision: D97540060
bbeckca
force-pushed
the
export-D97540060
branch
from
07faeaf to
f8da8fd
Compare
jcaip
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
What: Add a guard in test/sparsity/test_sparse_api.py so tests that depend on
hipSPARSELtonly run when the backend is available.Why: These tests currently fail on environments without hipSPARSELt, for example OSS AO nightly. Since the functionality is environment dependent, these test should be conditionally skipped. https://fburl.com/9fpszdqg
Differential Revision: D97540060