[ROCm] Enable FP8 QAT test on MI300/MI350#4132
Merged
andrewor14 merged 1 commit intopytorch:mainfrom Apr 1, 2026
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4132
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 0d5a269 with merge base 4cef023 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
andrewor14
approved these changes
Mar 23, 2026
Contributor
Author
|
@andrewor14 Thanks for the approval! This is mergeable and CI is green (the CUDA nightly failure looks like a pre-existing infra issue). Could you merge when you get a chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FP8 QAT test (
test_quantize_api_fp8_fp8) was gated onis_sm_at_least_89(), which excluded AMD GPUs. MI300 and MI350 both support FP8 dynamic activation + FP8 weight quantization with PerTensor and PerRow granularity, so this updates the skip condition to also allow MI300/MI350.Tested locally on MI300X -- both PerTensor and PerRow variants pass.