Skip to content

[ROCm] Enable FP8 QAT test on MI300/MI350#4132

Merged
andrewor14 merged 1 commit intopytorch:mainfrom
brucechanglongxu:rocm-enable-qat-fp8-test
Apr 1, 2026
Merged

[ROCm] Enable FP8 QAT test on MI300/MI350#4132
andrewor14 merged 1 commit intopytorch:mainfrom
brucechanglongxu:rocm-enable-qat-fp8-test

Conversation

@brucechanglongxu
Copy link
Copy Markdown
Contributor

The FP8 QAT test (test_quantize_api_fp8_fp8) was gated on is_sm_at_least_89(), which excluded AMD GPUs. MI300 and MI350 both support FP8 dynamic activation + FP8 weight quantization with PerTensor and PerRow granularity, so this updates the skip condition to also allow MI300/MI350.

Tested locally on MI300X -- both PerTensor and PerRow variants pass.

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Mar 22, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4132

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 0d5a269 with merge base 4cef023 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 22, 2026
@brucechanglongxu
Copy link
Copy Markdown
Contributor Author

@andrewor14 Thanks for the approval! This is mergeable and CI is green (the CUDA nightly failure looks like a pre-existing infra issue). Could you merge when you get a chance?

@andrewor14 andrewor14 merged commit 6807454 into pytorch:main Apr 1, 2026
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: rocm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants