Add alg_id argument to SemiSparseWeightConfig (#4238)#4238
Merged
jerryzh168 merged 1 commit intopytorch:mainfrom Apr 7, 2026
Merged
Add alg_id argument to SemiSparseWeightConfig (#4238)#4238jerryzh168 merged 1 commit intopytorch:mainfrom
jerryzh168 merged 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4238
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c873eea with merge base d26bbae ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@RandySheriff has exported this pull request. If you are a Meta employee, you can view the originating Diff in D99485146. |
RandySheriff
added a commit
to RandySheriff/ao
that referenced
this pull request
Apr 3, 2026
Summary: As titled, by adding the alg_id, we now have chance to select most appropriate algorithm for optimal perf for specific gemm shapes ~ Differential Revision: D99485146
5f77bd0 to
72c9568
Compare
RandySheriff
added a commit
to RandySheriff/ao
that referenced
this pull request
Apr 3, 2026
Summary: As titled, by adding the alg_id, we now have chance to select most appropriate algorithm for optimal perf for specific gemm shapes ~ Differential Revision: D99485146
72c9568 to
3bd2dd7
Compare
Contributor
Author
|
@pytorchbot retest this please |
|
❌ 🤖 pytorchbot command failed: Try |
Contributor
Author
|
@pytorchbot fix-lint |
jerryzh168
reviewed
Apr 3, 2026
Contributor
this doesn't work in torchao right now btw, I'm trying to figure out how to get something like this work |
RandySheriff
added a commit
to RandySheriff/ao
that referenced
this pull request
Apr 3, 2026
Summary: As titled, by adding the alg_id, we now have chance to select most appropriate algorithm for optimal perf for specific gemm shapes ~ Differential Revision: D99485146
3bd2dd7 to
8dd8c54
Compare
RandySheriff
added a commit
to RandySheriff/ao
that referenced
this pull request
Apr 3, 2026
Summary: As titled, by adding the alg_id, we now have chance to select most appropriate algorithm for optimal perf for specific gemm shapes ~ Differential Revision: D99485146
8dd8c54 to
4762088
Compare
RandySheriff
added a commit
to RandySheriff/ao
that referenced
this pull request
Apr 6, 2026
Summary: As titled, by adding the alg_id, we now have chance to select most appropriate algorithm for optimal perf for specific gemm shapes ~ https://www.internalfb.com/sandcastle/workflow/1247497096797230266 Differential Revision: D99485146
4762088 to
5655c53
Compare
RandySheriff
added a commit
to RandySheriff/ao
that referenced
this pull request
Apr 6, 2026
Summary: As titled, by adding the alg_id, we now have chance to select most appropriate algorithm for optimal perf for specific gemm shapes ~ Differential Revision: D99485146
5655c53 to
9adab04
Compare
RandySheriff
added a commit
to RandySheriff/ao
that referenced
this pull request
Apr 6, 2026
Summary: As titled, by adding the alg_id, we now have chance to select most appropriate algorithm for optimal perf for specific gemm shapes ~ Differential Revision: D99485146
9adab04 to
00c66c9
Compare
RandySheriff
added a commit
to RandySheriff/ao
that referenced
this pull request
Apr 6, 2026
Summary: As titled, by adding the alg_id, we now have chance to select most appropriate algorithm for optimal perf for specific gemm shapes ~ Fixes: - Fixed typo "activiation" → "activation" in test - Fixed formatting: line length violations and inconsistent indentation in `mm_search` call - Moved `__post_init__` API usage logging into `__init__` in `SemiSparseWeightConfig`, since the class is not a `dataclass` and `__post_init__` was dead code --- > Generated by [RACER](https://www.internalfb.com/wiki/RACER_(Risk-Aware_Code_Editing_and_Refactoring)/), powered by [Confucius](https://www.internalfb.com/wiki/Confucius/Analect/Shared_Analects/Confucius_Code_Assist_(CCA)/) [Session](https://www.internalfb.com/confucius?session_id=b3d5061c-31f8-11f1-9a22-a5a2fb0b80aa&tab=Chat), [Trace](https://www.internalfb.com/confucius?session_id=b3d5061c-31f8-11f1-9a22-a5a2fb0b80aa&tab=Trace) Differential Revision: D99485146
00c66c9 to
bac71e1
Compare
RandySheriff
added a commit
to RandySheriff/ao
that referenced
this pull request
Apr 6, 2026
Summary: As titled, by adding the alg_id, we now have chance to select most appropriate algorithm for optimal perf for specific gemm shapes ~ Fixes: - Fixed typo "activiation" → "activation" in test - Fixed formatting: line length violations and inconsistent indentation in `mm_search` call - Moved `__post_init__` API usage logging into `__init__` in `SemiSparseWeightConfig`, since the class is not a `dataclass` and `__post_init__` was dead code --- > Generated by [RACER](https://www.internalfb.com/wiki/RACER_(Risk-Aware_Code_Editing_and_Refactoring)/), powered by [Confucius](https://www.internalfb.com/wiki/Confucius/Analect/Shared_Analects/Confucius_Code_Assist_(CCA)/) [Session](https://www.internalfb.com/confucius?session_id=b3d5061c-31f8-11f1-9a22-a5a2fb0b80aa&tab=Chat), [Trace](https://www.internalfb.com/confucius?session_id=b3d5061c-31f8-11f1-9a22-a5a2fb0b80aa&tab=Trace) Differential Revision: D99485146
ebd1465 to
0ba7e5a
Compare
RandySheriff
added a commit
to RandySheriff/ao
that referenced
this pull request
Apr 6, 2026
Summary: Pull Request resolved: pytorch#4238 As titled, by adding the alg_id, we now have chance to select most appropriate algorithm for optimal perf for specific gemm shapes ~ Fixes: - Fixed typo "activiation" → "activation" in test - Fixed formatting: line length violations and inconsistent indentation in `mm_search` call - Moved `__post_init__` API usage logging into `__init__` in `SemiSparseWeightConfig`, since the class is not a `dataclass` and `__post_init__` was dead code --- > Generated by [RACER](https://www.internalfb.com/wiki/RACER_(Risk-Aware_Code_Editing_and_Refactoring)/), powered by [Confucius](https://www.internalfb.com/wiki/Confucius/Analect/Shared_Analects/Confucius_Code_Assist_(CCA)/) [Session](https://www.internalfb.com/confucius?session_id=b3d5061c-31f8-11f1-9a22-a5a2fb0b80aa&tab=Chat), [Trace](https://www.internalfb.com/confucius?session_id=b3d5061c-31f8-11f1-9a22-a5a2fb0b80aa&tab=Trace) Differential Revision: D99485146
RandySheriff
added a commit
to RandySheriff/ao
that referenced
this pull request
Apr 6, 2026
Summary: As titled, by adding the alg_id, we now have chance to select most appropriate algorithm for optimal perf for specific gemm shapes ~ Fixes: - Fixed typo "activiation" → "activation" in test - Fixed formatting: line length violations and inconsistent indentation in `mm_search` call - Moved `__post_init__` API usage logging into `__init__` in `SemiSparseWeightConfig`, since the class is not a `dataclass` and `__post_init__` was dead code --- > Generated by [RACER](https://www.internalfb.com/wiki/RACER_(Risk-Aware_Code_Editing_and_Refactoring)/), powered by [Confucius](https://www.internalfb.com/wiki/Confucius/Analect/Shared_Analects/Confucius_Code_Assist_(CCA)/) [Session](https://www.internalfb.com/confucius?session_id=b3d5061c-31f8-11f1-9a22-a5a2fb0b80aa&tab=Chat), [Trace](https://www.internalfb.com/confucius?session_id=b3d5061c-31f8-11f1-9a22-a5a2fb0b80aa&tab=Trace) Differential Revision: D99485146
0ba7e5a to
7e407ab
Compare
RandySheriff
added a commit
to RandySheriff/ao
that referenced
this pull request
Apr 6, 2026
Summary: As titled, by adding the alg_id, we now have chance to select most appropriate algorithm for optimal perf for specific gemm shapes ~ Fixes: - Fixed typo "activiation" → "activation" in test - Fixed formatting: line length violations and inconsistent indentation in `mm_search` call - Moved `__post_init__` API usage logging into `__init__` in `SemiSparseWeightConfig`, since the class is not a `dataclass` and `__post_init__` was dead code --- > Generated by [RACER](https://www.internalfb.com/wiki/RACER_(Risk-Aware_Code_Editing_and_Refactoring)/), powered by [Confucius](https://www.internalfb.com/wiki/Confucius/Analect/Shared_Analects/Confucius_Code_Assist_(CCA)/) [Session](https://www.internalfb.com/confucius?session_id=b3d5061c-31f8-11f1-9a22-a5a2fb0b80aa&tab=Chat), [Trace](https://www.internalfb.com/confucius?session_id=b3d5061c-31f8-11f1-9a22-a5a2fb0b80aa&tab=Trace) Differential Revision: D99485146
7e407ab to
b78b831
Compare
RandySheriff
added a commit
to RandySheriff/ao
that referenced
this pull request
Apr 6, 2026
Summary: As titled, by adding the alg_id, we now have chance to select most appropriate algorithm for optimal perf for specific gemm shapes ~ Fixes: - Fixed typo "activiation" → "activation" in test - Fixed formatting: line length violations and inconsistent indentation in `mm_search` call - Moved `__post_init__` API usage logging into `__init__` in `SemiSparseWeightConfig`, since the class is not a `dataclass` and `__post_init__` was dead code --- > Generated by [RACER](https://www.internalfb.com/wiki/RACER_(Risk-Aware_Code_Editing_and_Refactoring)/), powered by [Confucius](https://www.internalfb.com/wiki/Confucius/Analect/Shared_Analects/Confucius_Code_Assist_(CCA)/) [Session](https://www.internalfb.com/confucius?session_id=b3d5061c-31f8-11f1-9a22-a5a2fb0b80aa&tab=Chat), [Trace](https://www.internalfb.com/confucius?session_id=b3d5061c-31f8-11f1-9a22-a5a2fb0b80aa&tab=Trace) Differential Revision: D99485146
b78b831 to
c6e63f5
Compare
RandySheriff
added a commit
to RandySheriff/ao
that referenced
this pull request
Apr 6, 2026
Summary: As titled, by adding the alg_id, we now have chance to select most appropriate algorithm for optimal perf for specific gemm shapes ~ Fixes: - Fixed typo "activiation" → "activation" in test - Fixed formatting: line length violations and inconsistent indentation in `mm_search` call - Moved `__post_init__` API usage logging into `__init__` in `SemiSparseWeightConfig`, since the class is not a `dataclass` and `__post_init__` was dead code --- > Generated by [RACER](https://www.internalfb.com/wiki/RACER_(Risk-Aware_Code_Editing_and_Refactoring)/), powered by [Confucius](https://www.internalfb.com/wiki/Confucius/Analect/Shared_Analects/Confucius_Code_Assist_(CCA)/) [Session](https://www.internalfb.com/confucius?session_id=b3d5061c-31f8-11f1-9a22-a5a2fb0b80aa&tab=Chat), [Trace](https://www.internalfb.com/confucius?session_id=b3d5061c-31f8-11f1-9a22-a5a2fb0b80aa&tab=Trace) Differential Revision: D99485146
c6e63f5 to
16bc4a8
Compare
RandySheriff
added a commit
to RandySheriff/ao
that referenced
this pull request
Apr 6, 2026
Summary: As titled, by adding the alg_id, we now have chance to select most appropriate algorithm for optimal perf for specific gemm shapes ~ Fixes: - Fixed typo "activiation" → "activation" in test - Fixed formatting: line length violations and inconsistent indentation in `mm_search` call - Moved `__post_init__` API usage logging into `__init__` in `SemiSparseWeightConfig`, since the class is not a `dataclass` and `__post_init__` was dead code --- > Generated by [RACER](https://www.internalfb.com/wiki/RACER_(Risk-Aware_Code_Editing_and_Refactoring)/), powered by [Confucius](https://www.internalfb.com/wiki/Confucius/Analect/Shared_Analects/Confucius_Code_Assist_(CCA)/) [Session](https://www.internalfb.com/confucius?session_id=b3d5061c-31f8-11f1-9a22-a5a2fb0b80aa&tab=Chat), [Trace](https://www.internalfb.com/confucius?session_id=b3d5061c-31f8-11f1-9a22-a5a2fb0b80aa&tab=Trace) Differential Revision: D99485146
16bc4a8 to
be72211
Compare
jerryzh168
approved these changes
Apr 6, 2026
RandySheriff
added a commit
to RandySheriff/ao
that referenced
this pull request
Apr 7, 2026
Summary: As titled, by adding the alg_id, we now have chance to select most appropriate algorithm for optimal perf for specific gemm shapes ~ Fixes: - Fixed typo "activiation" → "activation" in test - Fixed formatting: line length violations and inconsistent indentation in `mm_search` call - Moved `__post_init__` API usage logging into `__init__` in `SemiSparseWeightConfig`, since the class is not a `dataclass` and `__post_init__` was dead code --- > Generated by [RACER](https://www.internalfb.com/wiki/RACER_(Risk-Aware_Code_Editing_and_Refactoring)/), powered by [Confucius](https://www.internalfb.com/wiki/Confucius/Analect/Shared_Analects/Confucius_Code_Assist_(CCA)/) [Session](https://www.internalfb.com/confucius?session_id=b3d5061c-31f8-11f1-9a22-a5a2fb0b80aa&tab=Chat), [Trace](https://www.internalfb.com/confucius?session_id=b3d5061c-31f8-11f1-9a22-a5a2fb0b80aa&tab=Trace) Differential Revision: D99485146
be72211 to
d8f20dc
Compare
RandySheriff
added a commit
to RandySheriff/ao
that referenced
this pull request
Apr 7, 2026
Summary: As titled, by adding the alg_id, we now have chance to select most appropriate algorithm for optimal perf for specific gemm shapes ~ Fixes: - Fixed typo "activiation" → "activation" in test - Fixed formatting: line length violations and inconsistent indentation in `mm_search` call - Moved `__post_init__` API usage logging into `__init__` in `SemiSparseWeightConfig`, since the class is not a `dataclass` and `__post_init__` was dead code --- > Generated by [RACER](https://www.internalfb.com/wiki/RACER_(Risk-Aware_Code_Editing_and_Refactoring)/), powered by [Confucius](https://www.internalfb.com/wiki/Confucius/Analect/Shared_Analects/Confucius_Code_Assist_(CCA)/) [Session](https://www.internalfb.com/confucius?session_id=b3d5061c-31f8-11f1-9a22-a5a2fb0b80aa&tab=Chat), [Trace](https://www.internalfb.com/confucius?session_id=b3d5061c-31f8-11f1-9a22-a5a2fb0b80aa&tab=Trace) Differential Revision: D99485146
d8f20dc to
01eb4ad
Compare
RandySheriff
added a commit
to RandySheriff/ao
that referenced
this pull request
Apr 7, 2026
Summary: As titled, by adding the alg_id, we now have chance to select most appropriate algorithm for optimal perf for specific gemm shapes ~ Fixes: - Fixed typo "activiation" → "activation" in test - Fixed formatting: line length violations and inconsistent indentation in `mm_search` call - Moved `__post_init__` API usage logging into `__init__` in `SemiSparseWeightConfig`, since the class is not a `dataclass` and `__post_init__` was dead code --- > Generated by [RACER](https://www.internalfb.com/wiki/RACER_(Risk-Aware_Code_Editing_and_Refactoring)/), powered by [Confucius](https://www.internalfb.com/wiki/Confucius/Analect/Shared_Analects/Confucius_Code_Assist_(CCA)/) [Session](https://www.internalfb.com/confucius?session_id=b3d5061c-31f8-11f1-9a22-a5a2fb0b80aa&tab=Chat), [Trace](https://www.internalfb.com/confucius?session_id=b3d5061c-31f8-11f1-9a22-a5a2fb0b80aa&tab=Trace) Differential Revision: D99485146
01eb4ad to
d97a6ec
Compare
Summary: As titled, by adding the alg_id, we now have chance to select most appropriate algorithm for optimal perf for specific gemm shapes ~ Fixes: - Fixed typo "activiation" → "activation" in test - Fixed formatting: line length violations and inconsistent indentation in `mm_search` call - Moved `__post_init__` API usage logging into `__init__` in `SemiSparseWeightConfig`, since the class is not a `dataclass` and `__post_init__` was dead code --- > Generated by [RACER](https://www.internalfb.com/wiki/RACER_(Risk-Aware_Code_Editing_and_Refactoring)/), powered by [Confucius](https://www.internalfb.com/wiki/Confucius/Analect/Shared_Analects/Confucius_Code_Assist_(CCA)/) [Session](https://www.internalfb.com/confucius?session_id=b3d5061c-31f8-11f1-9a22-a5a2fb0b80aa&tab=Chat), [Trace](https://www.internalfb.com/confucius?session_id=b3d5061c-31f8-11f1-9a22-a5a2fb0b80aa&tab=Trace) Differential Revision: D99485146
d97a6ec to
c873eea
Compare
brucechanglongxu
pushed a commit
to brucechanglongxu/ao
that referenced
this pull request
Apr 9, 2026
…#4238) Summary: As titled, by adding the alg_id, we now have chance to select most appropriate algorithm for optimal perf for specific gemm shapes ~ Fixes: - Fixed typo "activiation" → "activation" in test - Fixed formatting: line length violations and inconsistent indentation in `mm_search` call - Moved `__post_init__` API usage logging into `__init__` in `SemiSparseWeightConfig`, since the class is not a `dataclass` and `__post_init__` was dead code --- > Generated by [RACER](https://www.internalfb.com/wiki/RACER_(Risk-Aware_Code_Editing_and_Refactoring)/), powered by [Confucius](https://www.internalfb.com/wiki/Confucius/Analect/Shared_Analects/Confucius_Code_Assist_(CCA)/) [Session](https://www.internalfb.com/confucius?session_id=b3d5061c-31f8-11f1-9a22-a5a2fb0b80aa&tab=Chat), [Trace](https://www.internalfb.com/confucius?session_id=b3d5061c-31f8-11f1-9a22-a5a2fb0b80aa&tab=Trace) Differential Revision: D99485146
brucechanglongxu
pushed a commit
to brucechanglongxu/ao
that referenced
this pull request
Apr 9, 2026
…#4238) Summary: As titled, by adding the alg_id, we now have chance to select most appropriate algorithm for optimal perf for specific gemm shapes ~ Fixes: - Fixed typo "activiation" → "activation" in test - Fixed formatting: line length violations and inconsistent indentation in `mm_search` call - Moved `__post_init__` API usage logging into `__init__` in `SemiSparseWeightConfig`, since the class is not a `dataclass` and `__post_init__` was dead code --- > Generated by [RACER](https://www.internalfb.com/wiki/RACER_(Risk-Aware_Code_Editing_and_Refactoring)/), powered by [Confucius](https://www.internalfb.com/wiki/Confucius/Analect/Shared_Analects/Confucius_Code_Assist_(CCA)/) [Session](https://www.internalfb.com/confucius?session_id=b3d5061c-31f8-11f1-9a22-a5a2fb0b80aa&tab=Chat), [Trace](https://www.internalfb.com/confucius?session_id=b3d5061c-31f8-11f1-9a22-a5a2fb0b80aa&tab=Trace) Differential Revision: D99485146
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
As titled, by adding the alg_id, we now have chance to select most appropriate algorithm for optimal perf for specific gemm shapes ~