Add minimal ffmpeg build to linux wheel job envs #2137
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 tasks
carolineechen
approved these changes
Jan 5, 2022
Contributor
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
nateanl
approved these changes
Jan 5, 2022
xiaohui-zhang
pushed a commit
to xiaohui-zhang/audio
that referenced
this pull request
May 4, 2022
Summary: This change adds a minimal ffmpeg installation step to the build wheel job so that later, we can use the resulting ffmpeg libraries for building torchaudio's ffmpeg-features. The linux wheel build jobs run in CentOS 8 based environment, which does not provide an easy way to install ffmpeg without conda. After pytorch#2124 is merged, then we can enable the ffmpeg-feature build in Linux wheel. Pull Request resolved: pytorch#2137 Reviewed By: carolineechen Differential Revision: D33430032 Pulled By: mthrok fbshipit-source-id: bf946d394c0718ddbdc679d7970befc3221982b9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a minimal ffmpeg installation step to the build wheel job so that later, we can use the resulting ffmpeg libraries for building torchaudio's ffmpeg-features.
The linux wheel build jobs run in CentOS 8 based environment, which does not provide an easy way to install ffmpeg without conda.
After #2124 is merged, then we can enable the ffmpeg-feature build in Linux wheel.