Ignore TempDir clean up error #2379
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On CircleCI, Windows unittests are failing for Python 3.7 with `PermissionError` at the end of test when it cleans up temporary directory. According to the discussion python/cpython#74168, this is caused by a known issue with `shutil.rmtree`. In the above thread it is advised to simply ignore the error as it is not guaranteed that temp directories are cleaned up. This commit follows the same path and simply ignore the error so that our CI gets back to green.
mthrok
force-pushed
the
fix-windows-temp-dir
branch
from
6c0b3ca to
e93ee9c
Compare
Contributor
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
carolineechen
approved these changes
May 11, 2022
Contributor
carolineechen
left a comment
carolineechen
left a comment
There was a problem hiding this comment.
looks good, thanks!
|
Hey @mthrok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On CircleCI, Windows unittests are failing for Python 3.7 with
PermissionErrorat the end of test when it cleans up temporarydirectory.
According to the discussion python/cpython#74168,
this is caused by a known issue with
shutil.rmtree.In the above thread it is advised to simply ignore the error as it
is not guaranteed that temp directories are cleaned up.
This commit follows the same path and simply ignore the error
so that our CI gets back to green.