Skip to content

Conversation

@DanilBaibak
Copy link
Contributor

@DanilBaibak DanilBaibak commented Dec 7, 2022

Switch to Nova Linux Wheel build.

  • Disable the CircleCI builds for Linux Wheel.
  • Enable the Nova workflow for Linux Wheel.

The Linux Wheel Python3.8 build has been kept because it is a dependency for the docstring_parameters_sync job. As Omkar pointed out, Docstring Parameters Sync also runs on GHA (https://github.com/pytorch/audio/actions/runs/3638187635/jobs/6140090209). So, we completely switched to the Nova Linux Wheel build.

@DanilBaibak DanilBaibak changed the title Switch to nova linux pip build Switch to nova Linux Wheel build Dec 7, 2022
Copy link
Contributor

@osalpekar osalpekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my end. Looks like the expected jobs are green and AFAICT the failing jobs are unrelated to this change. would love to know @hwangjeff 's thoughts

@DanilBaibak DanilBaibak requested a review from osalpekar December 8, 2022 14:06
@DanilBaibak DanilBaibak requested a review from mthrok December 12, 2022 09:53
Copy link
Contributor

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know how the binaries are built on GHA, but assuming that they are built fine, the change looks reasonable.

with:
repository: ${{ matrix.repository }}
ref: nightly
ref: ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do? At a glance, it might as well be omitted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to use the main branch from the pytorch/test-infra repo.

@facebook-github-bot
Copy link
Contributor

@DanilBaibak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@DanilBaibak merged this pull request in ad596b3.

@github-actions
Copy link

Hey @DanilBaibak.
You merged this PR, but labels were not properly added. Please add a primary and secondary label (See https://github.com/pytorch/audio/blob/main/.github/process_commit.py)

@mthrok mthrok deleted the Switch-to-Nova-Linux-pip branch July 18, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants