-
Notifications
You must be signed in to change notification settings - Fork 759
Switch to nova Linux Wheel build #2896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from my end. Looks like the expected jobs are green and AFAICT the failing jobs are unrelated to this change. would love to know @hwangjeff 's thoughts
mthrok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not know how the binaries are built on GHA, but assuming that they are built fine, the change looks reasonable.
| with: | ||
| repository: ${{ matrix.repository }} | ||
| ref: nightly | ||
| ref: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do? At a glance, it might as well be omitted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to use the main branch from the pytorch/test-infra repo.
|
@DanilBaibak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@DanilBaibak merged this pull request in ad596b3. |
|
Hey @DanilBaibak. |
Switch to Nova Linux Wheel build.
The Linux Wheel Python3.8 build has been kept because it is a dependency for theAs Omkar pointed out, Docstring Parameters Sync also runs on GHA (https://github.com/pytorch/audio/actions/runs/3638187635/jobs/6140090209). So, we completely switched to the Nova Linux Wheel build.docstring_parameters_syncjob.