Bind StreamReader/Writer with PyBind11 #3091
Conversation
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mthrok
force-pushed
the
update-ffmpeg-binding
branch
10 times, most recently
from
6f8baab to
7ff7590
Compare
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mthrok
force-pushed
the
update-ffmpeg-binding
branch
from
7ff7590 to
4ddee36
Compare
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mthrok
force-pushed
the
update-ffmpeg-binding
branch
from
4ddee36 to
b72cda0
Compare
mthrok
changed the title
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mthrok
force-pushed
the
update-ffmpeg-binding
branch
from
b72cda0 to
effd933
Compare
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was exported from Phabricator. Differential Revision: D43515714 |
Summary: This commit is kind of clean up and preparation for future development. We plan to pass around more complicated objects among StreamReader and StreamWriter, and TorchBind is not expressive enough for defining intermediate object, so we use PyBind11 for binding StreamWriter. Pull Request resolved: pytorch#3091 Differential Revision: D43515714 Pulled By: mthrok fbshipit-source-id: 28f5a02eedc58a2754fe8e938619569b26df14ee
mthrok
force-pushed
the
update-ffmpeg-binding
branch
from
effd933 to
a366a11
Compare
Summary: This commit is kind of clean up and preparation for future development. We plan to pass around more complicated objects among StreamReader and StreamWriter, and TorchBind is not expressive enough for defining intermediate object, so we use PyBind11 for binding StreamWriter. Pull Request resolved: pytorch#3091 Differential Revision: D43515714 Pulled By: mthrok fbshipit-source-id: cd46cd846320190fcb574c1f05ac5eff0bf2f58e
mthrok
force-pushed
the
update-ffmpeg-binding
branch
from
a366a11 to
4c1d44b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D43515714 |
|
Hey @mthrok. |
2 participants
This commit is kind of clean up and preparation for future
development.
We plan to pass around more complicated objects among
StreamReader and StreamWriter, and TorchBind is not expressive enough
for defining intermediate object, so we use PyBind11 for binding
StreamWriter.