Fix HW accelerated encoder #3140
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D43759162 |
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Mar 3, 2023
Summary: Pull Request resolved: pytorch#3140 pytorch#3120 introduced regression in GPU encoder. This happened because previously source AVPixelFormat (expected channel order of input tensor) and AVCodecContext (encoding format) in converter (module to copy input tensor to buffer), even though converter does not need to konw about the encoding format. This commit fixes the issue and make sure that converter does not recieve codec context. Differential Revision: D43759162 fbshipit-source-id: a4d76034312d42ce2267daeafe84d87ef91200cb
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D43759162 |
Summary: Pull Request resolved: pytorch#3140 pytorch#3120 introduced regression in GPU encoder. This happened because previously source AVPixelFormat (expected channel order of input tensor) and AVCodecContext (encoding format) in converter (module to copy input tensor to buffer), even though converter does not need to konw about the encoding format. This commit fixes the issue and make sure that converter does not recieve codec context. Reviewed By: nateanl Differential Revision: D43759162 fbshipit-source-id: c3b2a8b5afad0c8e084a6b58c1c073b487da5f43
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D43759162 |
Contributor
|
This pull request has been merged in 41e3b93. |
|
Hey @None. |
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Mar 3, 2023
Summary: Similar to pytorch#3140, only provide objects which are semantically related to the operation performed by AudioConverter. Differential Revision: D43781012 fbshipit-source-id: e60d3afab3cf224aca6140efa5f4e09088e6859f
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Mar 3, 2023
Summary: Similar to pytorch#3140, only provide objects which are semantically related to the operation performed by AudioConverter. Reviewed By: xiaohui-zhang Differential Revision: D43781012 fbshipit-source-id: b70d76b6886fe59ca21e47c6c8610aac6e96162e
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Mar 4, 2023
Summary: Similar to pytorch#3140, only provide objects which are semantically related to the operation performed by AudioConverter. Differential Revision: D43781012 fbshipit-source-id: e60d3afab3cf224aca6140efa5f4e09088e6859f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
#3120 introduced regression in GPU encoder.
This happened because previously source AVPixelFormat (expected channel order of
input tensor) and AVCodecContext (encoding format) in converter (module to copy
input tensor to buffer), even though converter does not need to konw about the
encoding format.
This commit fixes the issue and make sure that converter does not recieve
codec context.
Differential Revision: D43759162