Skip to content

Conversation

@carljparker
Copy link
Contributor

Previously, breadcrumbs.html identified a nightly build version by the prefix "Nightly" which would normally be prepended to the version in conf.py. However, the version string is coming through without the "Nightly" prefix, so this change causes breadcrumbs.html to key on the substring "dev" instead.

The reason we aren't getting "Nightly" is apparently because the environment variable BUILD_VERSION is available, so conf.py is using the value of that env var instead of the version string imported from the torchaudio module itself, which actually appears to be incorrect; see below.

If I install torchaudio using

conda install torchaudio -c pytorch-nightly

then torchaudio.__version__ returns the incorrect version string:

2.0.0.dev20230309

Previously, `breadcrumbs.html` identified a nightly build version by the
prefix "Nightly" which would normally be prepended to the version in
`conf.py`. However, the version string is coming through without the
"Nightly" prefix, so this change causes `breadcrumbs.html` to key on the
substring "dev" instead.

The reason we aren't getting "Nightly" is apparently because the
environment variable BUILD_VERSION is available, so `conf.py` is using
the value of that env var instead of the version string imported from
the `torchaudio` module itself, which appears to be incorrect.

If I install torchaudio using

    conda install torchaudio -c pytorch-nightly

then `torchaudio.__version__` returns the incorrect version string:

    2.0.0.dev20230309
@carljparker carljparker requested review from a team and mthrok May 15, 2023 03:13
@pytorch-bot
Copy link

pytorch-bot bot commented May 15, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3333

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 78429e7:

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Contributor

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@facebook-github-bot
Copy link
Contributor

@carljparker has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@carljparker merged this pull request in 3ffd76c.

@github-actions
Copy link

Hey @carljparker.
You merged this PR, but labels were not properly added. Please add a primary and secondary label (See https://github.com/pytorch/audio/blob/main/.github/process_commit.py).


Some guidance:

Use 'module: ops' for operations under 'torchaudio/{transforms, functional}', and ML-related components under 'torchaudio/csrc' (e.g. RNN-T loss).

Things in "examples" directory:

  • 'recipe' is applicable to training recipes under the 'examples' folder,
  • 'tutorial' is applicable to tutorials under the “examples/tutorials” folder
  • 'example' is applicable to everything else (e.g. C++ examples)
  • 'module: docs' is applicable to code documentations (not to tutorials).
    Regarding examples in code documentations, please also use 'module: docs'.

Please use 'other' tag only when you’re sure the changes are not much relevant to users, or when all other tags are not applicable. Try not to use it often, in order to minimize efforts required when we prepare release notes.


When preparing release notes, please make sure 'documentation' and 'tutorials' occur as the last sub-categories under each primary category like 'new feature', 'improvements' or 'prototype'.

Things related to build are by default excluded from the release note, except when it impacts users. For example:
* Drop support of Python 3.7.
* Add support of Python 3.X.
* Change the way a third party library is bound (so that user needs to install it separately).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants