Fix for breadcrumbs displaying "Old version (stable)" on Nightly build #3333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
breadcrumbs.htmlidentified a nightly build version by the prefix "Nightly" which would normally be prepended to the version inconf.py. However, the version string is coming through without the "Nightly" prefix, so this change causesbreadcrumbs.htmlto key on the substring "dev" instead.The reason we aren't getting "Nightly" is apparently because the environment variable BUILD_VERSION is available, so
conf.pyis using the value of that env var instead of the version string imported from thetorchaudiomodule itself, which actually appears to be incorrect; see below.If I install torchaudio using
then
torchaudio.__version__returns the incorrect version string: