[STABLE ABI] Use const/mutable_data_ptr templates instead of reinterpret_cast#4152
Merged
pearu merged 1 commit intopytorch:mainfrom Dec 11, 2025
Merged
[STABLE ABI] Use const/mutable_data_ptr templates instead of reinterpret_cast#4152pearu merged 1 commit intopytorch:mainfrom
pearu merged 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4152
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit ae36bce with merge base c9b37e9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pearu
force-pushed
the
pearu/elimnate-data_ptr
branch
from
829a7f9 to
ae36bce
Compare
NicolasHug
approved these changes
Dec 11, 2025
NicolasHug
pushed a commit
to NicolasHug/audio
that referenced
this pull request
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As in the title. The const/mutable_data_ptr templates are safer to use as these implement type check before casting.
PLEASE NOTE THAT THE TORCHAUDIO REPOSITORY IS NO LONGER ACTIVELY MONITORED. You may not get a response. For open discussions, visit https://discuss.pytorch.org/.