Skip to content

Fix CUCTC top-k shared memory offset#4198

Open
lanarkite99 wants to merge 1 commit into
pytorch:mainfrom
lanarkite99:resume/torchaudio-cuctc-topk-shmem
Open

Fix CUCTC top-k shared memory offset#4198
lanarkite99 wants to merge 1 commit into
pytorch:mainfrom
lanarkite99:resume/torchaudio-cuctc-topk-shmem

Conversation

@lanarkite99
Copy link
Copy Markdown

Fixes #4181

This fixes the shared-memory layout used by first_matrix__bitonic_topk_kernel.

block_topk_key is a float*, so pointer arithmetic is in units of float, not bytes. The previous code computed block_topk_key + sizeof(float) * beam, which advanced the value buffer by sizeof(float) * beam float elements instead of by beam float elements.

The launch allocates the result region as:

beam * sizeof(float) + beam * sizeof(int)

@lanarkite99 lanarkite99 requested a review from a team as a code owner June 1, 2026 17:45
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Jun 1, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4198

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Jun 1, 2026

Hi @lanarkite99!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Jun 1, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed label Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pointer arithmetic bug in first_matrix__bitonic_topk_kernel causes shared memory out-of-bounds write

1 participant