Skip to content

Include instructions for benchmark initial setup#133

Merged
wconstab merged 2 commits intomasterfrom
wconstab/add_setup_inst
Sep 29, 2020
Merged

Include instructions for benchmark initial setup#133
wconstab merged 2 commits intomasterfrom
wconstab/add_setup_inst

Conversation

@wconstab
Copy link
Copy Markdown
Contributor

No description provided.

This should still work, but misses installing `requirements.txt` in the top of tree.  Better to use install.py now.
Copy link
Copy Markdown
Contributor

@navahgar navahgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for updating this.

@wconstab wconstab merged commit 83b04ee into master Sep 29, 2020
@wconstab wconstab deleted the wconstab/add_setup_inst branch September 29, 2020 19:56
facebook-github-bot pushed a commit that referenced this pull request Jul 11, 2022
Summary:
README.md was edited by #133 but help message of test_bench.py is still saying `python test.py --setup_only`.

Fixed it.

Pull Request resolved: #1021

Reviewed By: george-qi

Differential Revision: D37760218

Pulled By: xuzhao9

fbshipit-source-id: 9e175ea68e7a4aa46509a2462748ad0c024886ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants