Refactor demucs get_module to return an nn.Module #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansel
commented
Feb 2, 2021
| :param y_qry: [querysz] | ||
| :return: | ||
| """ | ||
| assert len(x_spt.shape) == 4 |
Contributor
Author
There was a problem hiding this comment.
Note this is an unrelated change to make this module fx.symbolic_trace
wconstab
approved these changes
Feb 4, 2021
Contributor
|
@Krovatkin I am thinking you can get your PR in first and then try to rebase/merge this one on top, rather than have to change yours. |
Contributor
|
@wconstab Yes please! Lemme quickly address your comments and merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also removes a cpu=>gpu copy from the timed section of the code, so it will change the score.