Skip to content

Fix output filename bug, use deactivate instead of activate base. #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xuzhao9 merged 1 commit into from
Feb 3, 2021
+3 −3
Merged

Fix output filename bug, use deactivate instead of activate base. #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/scripts/run-nightly-nodocker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ for c in $(seq 1 $NUM_ITER); do
mv ${DATA_DIR}/${DATA_JSON_PREFIX}_${c}.json.tmp ${DATA_DIR}/${DATA_JSON_PREFIX}_${c}.json
done

. activate base
conda deactivate
conda env remove --name ${CONDA_ENV_NAME}

# Upload data to Sribe
Expand Down
4 changes: 2 additions & 2 deletions .github/scripts/run-sweep-nodocker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ set -euo pipefail
CONFIG_VER=v0
CONFIG_DIR=${PWD}/torchbenchmark/score/configs/${CONFIG_VER}
CONFIG_ENV=${CONFIG_DIR}/config-${CONFIG_VER}.env
DATA_JSON_PREFIX=$(date +"%Y%m%d_%H%M%S")
SWEEP_DIR="${HOME}/nightly-sweep"

# Load environment variables
Expand All @@ -30,6 +29,7 @@ for CONFIG in ${SWEEP_DIR}/configs/*.txt; do
# Create a new conda version from base
CONFIG_BASE=$(basename ${CONFIG})
CONFIG_ENV_NAME=gh-$(echo ${CONFIG} | sed 's/.*-\(.*\)\.txt/\1/')
DATA_JSON_PREFIX=$(date +"%Y%m%d_%H%M%S")
conda create -y -q --name ${CONFIG_ENV_NAME} python=${PYTHON_VERSION}
. activate ${CONFIG_ENV_NAME}
# Workaround of the torchtext dependency bug
Expand All @@ -49,7 +49,7 @@ for CONFIG in ${SWEEP_DIR}/configs/*.txt; do
${SWEEP_DIR}/${DATA_JSON_PREFIX}_${c}.json > ${SWEEP_DIR}/${DATA_JSON_PREFIX}_${c}.json.tmp
mv ${SWEEP_DIR}/${DATA_JSON_PREFIX}_${c}.json.tmp ${SWEEP_DIR}/${DATA_JSON_PREFIX}_${c}.json
done
. activate base
conda deactivate
conda env remove --name ${CONFIG_ENV_NAME}
done