Fix UDPOS imports for torchtext#266
Merged
Merged
Conversation
xuzhao9
requested changes
Feb 20, 2021
Contributor
There was a problem hiding this comment.
There are a few more references in the torchbenchmark repo (0.1 branch):
- https://github.com/pytorch/benchmark/blob/0.1/torchbenchmark/models/pytorch_struct/train.py#L23
- https://github.com/pytorch/benchmark/blob/0.1/torchbenchmark/models/attention_is_all_you_need_pytorch/translate.py#L9
- https://github.com/pytorch/benchmark/blob/0.1/torchbenchmark/models/pytorch_struct/train.py#L29
Can you help fix them as well?
added 2 commits
February 19, 2021 16:45
…hmark into fix_torchtext_UDPOS
Contributor
Author
Just added. Can you check? Somehow I missed these when I grepped :'( |
added 4 commits
February 19, 2021 16:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes torchtext imports for UDPOS in pytorch_struct