-
Notifications
You must be signed in to change notification settings - Fork 329
Add the runscript of PR test #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2eff017 to
19ba72e
Compare
19ba72e to
e66723d
Compare
wconstab
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems like it duplicates a lot of what is already done in other scripts. can another script be deleted now that this is added, or what is the difference?
Could you please point which script is the duplicate? In It is essentially the run-v0.sh on the 0.1 branch. But I would like the PR CI to be able to run all models available on the master branch, so I need to introduce this script to master. |
|
hmm, what about these scripts? it's possible the above are no longer used, and then I am OK with adding your new one and deleting the old ones. I also wonder if you have a plan for which scripts go in .github/scripts and which ones go in top-level scripts/. If it is not well organized, maybe just consider collapsing to use one folder. |
The |
Add the script to run the benchmark assuming the pytorch packages have been installed