Fix pytorch_struct broken by more strict in-place operation restrictions#408
Merged
Merged
Conversation
Contributor
|
Most likely caused by pytorch/pytorch#60195 |
Contributor
|
Yes that was a bug on our end were we were not detecting these inplace ops properly :/ |
Contributor
Author
Thanks for the response. This PR fixes the broken run, but will it also break the correctness? I guess in this case the ctx.saved_tensors won't be updated because we are using a copy. |
Contributor
|
Well, in this case, not modifying the saved_tensors inplace is the right fix and the code before had correctness issue. |
xuzhao9
added a commit
that referenced
this pull request
Jun 22, 2021
xuzhao9
added a commit
that referenced
this pull request
Jun 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent CI fails because pytorch restricts the usage of in-place operations. This PR fixes the failure by using copy of data structures instead of in-place operations.