Use taskset when GOMP_CPU_AFFINITY is set#430
Merged
Conversation
xuzhao9
approved these changes
Aug 24, 2021
|
|
||
| When GOMP_CPU_AFFINITY is set, importing `torch` in the main process has | ||
| the very surprising effect of changing the threading behavior in the | ||
| subprocess. (See https://github.com/pytorch/pytorch/issues/49971 for |
Contributor
There was a problem hiding this comment.
Maybe it is also worth mentioning using "torch.set_num_threads()" won't saturate the CPU resources?
xuzhao9
pushed a commit
to xuzhao9/benchmark
that referenced
this pull request
Aug 31, 2021
* use taskset when GOMP_CPU_AFFINITY is set * expand docstring of Worker
xuzhao9
pushed a commit
to xuzhao9/benchmark
that referenced
this pull request
Aug 31, 2021
* use taskset when GOMP_CPU_AFFINITY is set * expand docstring of Worker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out if we don't do this, TorchBench CI will run with a single CPU thread.